Remove capacity override from the forging functions#1182
Merged
Conversation
nfrisby
requested review from
RenateEilers,
amesgen,
dnadales,
fraser-iohk and
jasagredo
as code owners
nfrisby
changed the title
Merged
nfrisby
force-pushed
the
nfrisby/remove-cap-override-forge
branch
2 times, most recently
from
155bd42 to
f2a8354
Compare
amesgen
approved these changes
Jul 10, 2024
amesgen
left a comment
amesgen
left a comment
Contributor
There was a problem hiding this comment.
LGTM after changelog fragments etc.
This functionality seems to have been introduced based on IntersectMBO/ouroboros-network#3225 (implemented in IntersectMBO/ouroboros-network#3238), but I think it was never used in cardano-node (in contrast to the mempool size override, see IntersectMBO/cardano-node#3273 and IntersectMBO/cardano-node#3343, which will have to change in light of #1175 as one can only tweak the "multiplicity"/"block count" then).
It's undesirable for a node to make blocks that aren't full.
nfrisby
force-pushed
the
nfrisby/remove-cap-override-forge
branch
from
f2a8354 to
aa652d6
Compare
nfrisby
added a commit
that referenced
this pull request
Aug 28, 2024
BoundedMeasure is no longer necessary, as of PR #1182.
nfrisby
added a commit
that referenced
this pull request
Sep 3, 2024
BoundedMeasure is no longer necessary, as of PR #1182.
nfrisby
added a commit
that referenced
this pull request
Sep 3, 2024
BoundedMeasure is no longer necessary, as of PR #1182.
nfrisby
added a commit
that referenced
this pull request
Sep 4, 2024
BoundedMeasure is no longer necessary, as of PR #1182.
nfrisby
added a commit
that referenced
this pull request
Sep 4, 2024
BoundedMeasure is no longer necessary, as of PR #1182.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's undesirable for a node to make blocks that aren't full. Moreover, this parameter was only ever set to "no override" in our codebase and in the
cardano-noderepo. So it seems good and harmless to remove this.Note well that the capacity limit on the mempool is a separate parameter from the one removed by this PR.