Shelley mempool per-tx size check: do not include perTxOverhead#1352
Merged
Conversation
See the PR description for details
amesgen
requested review from
dnadales,
fraser-iohk,
geo2a,
jasagredo and
nfrisby
as code owners
jasagredo
approved these changes
Jan 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the previous logic, a tx that has less than
perTxOverhead = 4bytes less than the max tx size will be rejected by the mempool even though it is perfectly valid. This bug was introduced in #1175.This behavior could be rather surprising for users who create a big (but not too big) tx and then can't submit it to any node.
The fix is to use the "raw" size (without adding
perTxOverhead) for the check, but to still addperTxOverheadwhen returning theTxMeasure.Related: This code shouldn't live in Consensus (also see the module header), cf IntersectMBO/cardano-ledger#4820.