Conversation
* generate a tx cache using QuickCheck generators. * analyse a tx cache, output minumum, maximum and average tx size.
ec1fdd0 to
f729ce3
Compare
Once all txs are served, the outbound side can cleanly exit.
Use `WithBearer` with a custom `show` function.
* maximum number of txids to request * unackwnoledged buffer size
Increased span of mini-protocol numbers.
This avoids re-serialisation cost to get the size, increases allocation by storing bytes of the original `tx`.
WithBytes retains tx bytes for whole tx life time (e.g. until the inbound side exits), avoiding it we can GC the bytes after decoding is done and we extract the length of a tx.
./network-mux/demo/ns-setup.sh is a generic script for running client / server applications using traffic shaping. We can reuse it for `tx-submission` demo.
This makes it easier to analyse different runs, since all of them use the same connection four tuples.
Co-authored-by: Karl Knutsson <karl.fb.knutsson@gmail.com>
f729ce3 to
6e428f2
Compare
6e428f2 to
c4835ab
Compare
| local default_settings = { | ||
| -- the port used by `./network-mux/demo/mux-leios-demo.sh` | ||
| port = 9001, | ||
| port = 4000, |
There was a problem hiding this comment.
You want the port 9001 or none?
There was a problem hiding this comment.
I'd say leave it unchanged. If you need this to match to make your demo easier move the demo to use pot 9001.
crocodile-dentist
left a comment
There was a problem hiding this comment.
When running cabal run demo-tx-submission it outputs:
Missing: (COMMAND | COMMAND | COMMAND | COMMAND)
Usage: demo-tx-submission (COMMAND | COMMAND | COMMAND | COMMAND)
instead of one of the expected inbound, outbound, etc.
| min_mini_protocol_num = 1, | ||
| max_mini_protocol_num = 15, |
There was a problem hiding this comment.
Actually, this is not necessary and manually scanning for lost/OOO packets can be very slow. Wireshark can do this automatically, if you go to Edit->Preferences and select Protocols->TCP in the list on the left then ensure that 'Allow subdissector to reassemble TCP streams' and 'Reassemble out-of-order segments' are checked. Then some of the previous changes to this file can be reverted, or we can essentially re-use the ouroboros-network.lua dissector from @karknu, just including the new miniprotocols numbers for this demo.
Description
tx-submission-demoChecklist
Quality
Maintenance
ouroboros-networkproject.