Upgrade to contra-tracer 0.2.1#5368
Open
f-f wants to merge 1 commit into
Open
Conversation
coot
reviewed
May 14, 2026
Collaborator
coot
left a comment
coot
left a comment
There was a problem hiding this comment.
It LGTM, you just need to fix warnings since Contra.Tracer re-exports the >$<, and you'll also need to add QuickCheck < 2.18 constraints, since it renamed/deprecated a function we use.
f-f
force-pushed
the
f-f/contra-tracer-0.2
branch
from
bdacb91 to
2f6836a
Compare
f-f
force-pushed
the
f-f/contra-tracer-0.2
branch
from
2f6836a to
9e8ce37
Compare
Author
|
@coot thanks! I have applied the changes but I am getting a few test failures, could you have a look at those? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As part of the integration for 11.1, we'll be removing the legacy tracing
iohk-monitoring-framework- that needscontra-tracer >= 0.2.1, which this patch implements.Notes:
cabal.projectfile is set to override hackage packages with the CHaP ones, and we already have acontra-traceron CHaP as well, set to an earlier version. I am not sure what a better approach would be, so I'd be happy to hear suggestions on this (also for future occurrences)Checklist
Quality
Maintenance
ouroboros-networkproject.