Skip to content

Decouple bracketFetchClient and bracketKeepAlive#5371

Merged
coot merged 2 commits into
mainfrom
coot/bracketKeepAliveClient
May 15, 2026
Merged

Decouple bracketFetchClient and bracketKeepAlive#5371
coot merged 2 commits into
mainfrom
coot/bracketKeepAliveClient

Conversation

@coot
Copy link
Copy Markdown
Collaborator

@coot coot commented May 15, 2026

Description

Split FetchClientRegistry into two parts:

  • KeepAliveRegistry - keep-alive related
  • FetchClientRegistry - block-fetch related

Checklist

Quality

  • Commit sequence makes sense and have useful messages, see ref.
  • New tests are added and existing tests are updated.
  • Self-reviewed the PR.

Maintenance

  • Linked an issue or added the PR to the current sprint of ouroboros-network project.
  • Added labels.
  • Updated changelog files.
  • The documentation has been properly updated, see ref.

@coot coot requested a review from a team as a code owner May 15, 2026 07:37
@github-project-automation github-project-automation Bot moved this to In Progress in Ouroboros Network May 15, 2026
@coot coot added block-fetch Issues related to block fetch component. keep-alive Issues / PRs related to keep-alive protocol labels May 15, 2026
@coot coot self-assigned this May 15, 2026
@coot coot linked an issue May 15, 2026 that may be closed by this pull request
FetchClientRegistry was split into two parts, as a consequence
`bracketFetchClient` is decoupled from `bracketKeepAlive`.
@coot coot force-pushed the coot/bracketKeepAliveClient branch from 0fabb69 to b278958 Compare May 15, 2026 07:52
Exports of `BlockFetch.ClientRegistry` are preserved, so no consequences
for downstream libraries.
@coot coot force-pushed the coot/bracketKeepAliveClient branch from b278958 to 08a5ebe Compare May 15, 2026 11:57
Copy link
Copy Markdown
Contributor

@crocodile-dentist crocodile-dentist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@coot coot added this pull request to the merge queue May 15, 2026
Merged via the queue into main with commit e8d59d8 May 15, 2026
17 of 19 checks passed
@coot coot deleted the coot/bracketKeepAliveClient branch May 15, 2026 15:14
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Ouroboros Network May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

block-fetch Issues related to block fetch component. keep-alive Issues / PRs related to keep-alive protocol

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Decuple bracketKeepAliveClient from BlockFetch

2 participants