builtinsAvailableIn: revert from function to map#7232
Closed
kwxm wants to merge 2 commits into
Closed
Conversation
kwxm
added
Do not merge
EXPERIMENT
Contributor
Author
|
/benchmark validation-decode |
1 similar comment
Contributor
Author
|
/benchmark validation-decode |
Contributor
|
Click here to check the status of your benchmark. |
Contributor
Author
|
/benchmark validation-decode |
Contributor
|
Contributor
|
Comparing benchmark results of 'validation-decode' on '58d77d2c40' (base) and '937117ed0e' (PR) Results table
|
Contributor
|
Click here to check the status of your benchmark. |
Contributor
Author
|
/benchmark validation-full |
Contributor
|
Comparing benchmark results of 'validation-decode' on '58d77d2c40' (base) and '937117ed0e' (PR) Results table
|
Contributor
|
Click here to check the status of your benchmark. |
Contributor
|
Comparing benchmark results of 'validation-decode' on '58d77d2c40' (base) and '937117ed0e' (PR) Results table
|
Contributor
|
Click here to check the status of your benchmark. |
Contributor
|
(Note that this is for Comparing benchmark results of 'validation-full' on '58d77d2c40' (base) and '937117ed0e' (PR) Results table
|
Contributor
Author
|
/benchmark validation-decode |
2 similar comments
Contributor
Author
|
/benchmark validation-decode |
Contributor
Author
|
/benchmark validation-decode |
Contributor
|
Click here to check the status of your benchmark. |
Contributor
|
Click here to check the status of your benchmark. |
Contributor
|
Click here to check the status of your benchmark. |
effectfully
reviewed
Jul 24, 2025
| , ((PlutusV3, changPV), Set.fromList (batch1 ++ batch2 ++ batch3 ++ batch4)) | ||
| , ((PlutusV3, plominPV), Set.fromList batch5) | ||
| , ((PlutusV3, pv11PV), Set.fromList batch6) | ||
| ] |
Contributor
There was a problem hiding this comment.
It's fine, but I kinda liked previous version more, which you can make efficient if you follow this.
Contributor
Author
There was a problem hiding this comment.
I had to lift the separate batches out to the top level so that I could export them for use in the tests. I'll come back and try to improve the efficiency in a separate PR: I merged the less efficient version first so that I could experiment separately.
Oh wait, do you mean the version with the funciton rather than the map? It was originally a map but I switched to a function and that seems to have made it less efficient, so I was trying to confirm that and it seesm to be true. I'm experimenting with other ways to improve efficency in other branches.
Contributor
There was a problem hiding this comment.
Yeah, I mean you can keep it a function and have it efficient too.
Contributor
Author
|
/benchmark validation-decode |
Contributor
Author
|
/benchmark validation-decode |
Contributor
|
Click here to check the status of your benchmark. |
Contributor
|
Comparing benchmark results of 'validation-decode' on '0f4676fc39' (base) and '403fb8fe5c' (PR) Results table
|
Contributor
|
Click here to check the status of your benchmark. |
Contributor
|
Comparing benchmark results of 'validation-decode' on '0f4676fc39' (base) and '403fb8fe5c' (PR) Results table
|
Contributor
Author
|
I'm closing this because it's stale, but may come back and have another look at the original issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Experimenting with efficiency of
builtinsAvailableInafter #7223.