Skip to content

Commit d147e64

Browse files
Merge pull request #25 from Intreecom/feat/instrumentation-on-off-switch-for-taskiq
Gate taskiq instrumentation labels and annotations behind `taskiq.instrumentation.enabled` flag.
2 parents 9eb9c58 + 7f4914c commit d147e64

3 files changed

Lines changed: 10 additions & 4 deletions

File tree

charts/py-app/templates/taskiq-scheduler.yaml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,14 +13,16 @@ spec:
1313
deployment_type: tkq-scheduler
1414
template:
1515
metadata:
16-
{{- $podAnnotations := merge (deepCopy (default dict .Values.podAnnotations)) (default dict .Values.instrumentation.annotations) }}
16+
{{- $instrumentationAnnotations := ternary (default dict .Values.instrumentation.annotations) dict .Values.taskiq.instrumentation.enabled }}
17+
{{- $podAnnotations := merge (deepCopy (default dict .Values.podAnnotations)) $instrumentationAnnotations }}
1718
{{- with $podAnnotations }}
1819
annotations:
1920
{{- toYaml . | nindent 8 }}
2021
{{- end }}
2122
{{- $baseSelectorLabels := (include "py-app.selectorLabels" . | fromYaml) }}
2223
{{- $_ := set $baseSelectorLabels "deployment_type" "tkq-scheduler" }}
23-
{{- $mergedLabels := merge $baseSelectorLabels (default dict .Values.instrumentation.labels) }}
24+
{{- $instrumentationLabels := ternary (default dict .Values.instrumentation.labels) dict .Values.taskiq.instrumentation.enabled }}
25+
{{- $mergedLabels := merge $baseSelectorLabels $instrumentationLabels }}
2426
labels:
2527
{{- toYaml $mergedLabels | nindent 8 }}
2628
spec:

charts/py-app/templates/taskiq-worker.yaml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,14 +19,16 @@ spec:
1919
deployment_type: tkq-worker
2020
template:
2121
metadata:
22-
{{- $podAnnotations := merge (deepCopy (default dict .Values.podAnnotations)) (default dict .Values.instrumentation.annotations) }}
22+
{{- $instrumentationAnnotations := ternary (default dict .Values.instrumentation.annotations) dict .Values.taskiq.instrumentation.enabled }}
23+
{{- $podAnnotations := merge (deepCopy (default dict .Values.podAnnotations)) $instrumentationAnnotations }}
2324
{{- with $podAnnotations }}
2425
annotations:
2526
{{- toYaml . | nindent 8 }}
2627
{{- end }}
2728
{{- $baseSelectorLabels := (include "py-app.selectorLabels" . | fromYaml) }}
2829
{{- $_ := set $baseSelectorLabels "deployment_type" "tkq-worker" }}
29-
{{- $mergedLabels := merge $baseSelectorLabels (default dict .Values.instrumentation.labels) }}
30+
{{- $instrumentationLabels := ternary (default dict .Values.instrumentation.labels) dict .Values.taskiq.instrumentation.enabled }}
31+
{{- $mergedLabels := merge $baseSelectorLabels $instrumentationLabels }}
3032
labels:
3133
{{- toYaml $mergedLabels | nindent 8 }}
3234
spec:

charts/py-app/values.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,8 @@ taskiq:
3737
schedulerCmd: []
3838
resources: {}
3939
workers: 1
40+
instrumentation:
41+
enabled: false
4042
autoscaling:
4143
enabled: false
4244
minReplicas: 1

0 commit comments

Comments
 (0)