Merge branch 'main' into feature/bigquery-adapter

Author: raphael-intugle

pyproject.toml

@@ -83,6 +83,11 @@ mysql = [
     "sqlglot>=27.20.0",
 ]
 
+oracle = [
+    "oracledb>=2.0.0",
+    "sqlglot>=27.20.0",
+]
+
 streamlit = [
     "streamlit==1.50.0",
     "pyngrok==7.4.0",

src/intugle/adapters/factory.py

@@ -18,6 +18,14 @@ def import_module(name: str) -> ModuleInterface:
     return importlib.import_module(name)  # type: ignore
 
 
+# --- the new helper function ---
+def is_safe_plugin_name(plugin_name: str) -> bool:
+    """
+    Checks if the plugin belongs to the safe 'intugle.adapters.types' namespace.
+    """
+    return plugin_name.startswith("intugle.adapters.types.")
+
+
 DEFAULT_PLUGINS = [
     "intugle.adapters.types.pandas.pandas",
     "intugle.adapters.types.duckdb.duckdb",
@@ -28,6 +36,7 @@ def import_module(name: str) -> ModuleInterface:
     "intugle.adapters.types.sqlserver.sqlserver",
     "intugle.adapters.types.sqlite.sqlite",
     "intugle.adapters.types.bigquery.bigquery",
+    "intugle.adapters.types.oracle.oracle",
 ]
 
 
@@ -44,7 +53,7 @@ def __init__(self, plugins: list[dict] = None):
 
         for _plugin in plugins:
             # Security check: Ensure the plugin is in the correct namespace
-            if not _plugin.startswith("intugle.adapters.types."):
+            if not is_safe_plugin_name(_plugin):
                 print(f"Warning: Skipping potentially unsafe plugin '{_plugin}'.")
                 continue
             try:

src/intugle/adapters/models.py

@@ -22,12 +22,13 @@ def get_dataset_data_type() -> type:
     from intugle.adapters.types.bigquery.models import BigQueryConfig
     from intugle.adapters.types.databricks.models import DatabricksConfig
     from intugle.adapters.types.duckdb.models import DuckdbConfig
+    from intugle.adapters.types.oracle.models import OracleConfig
     from intugle.adapters.types.postgres.models import PostgresConfig
     from intugle.adapters.types.snowflake.models import SnowflakeConfig
     from intugle.adapters.types.sqlite.models import SqliteConfig
     from intugle.adapters.types.sqlserver.models import SQLServerConfig
 
-    DataSetData = pd.DataFrame | DuckdbConfig | SnowflakeConfig | DatabricksConfig | PostgresConfig | SQLServerConfig | SqliteConfig | BigQueryConfig
+    DataSetData = pd.DataFrame | DuckdbConfig | SnowflakeConfig | DatabricksConfig | PostgresConfig | SQLServerConfig | SqliteConfig | OracleConfig | BigQueryConfig
 else:
     # At runtime, this is dynamically determined
     DataSetData = Any

src/intugle/adapters/types/oracle/__init__.py

@@ -0,0 +1,24 @@
+from typing import Literal, Optional
+
+from pydantic import Field
+
+from intugle.common.schema import SchemaBase
+
+
+class OracleConnectionConfig(SchemaBase):
+    user: str
+    password: str
+    host: str
+    port: int = 1521
+    service_name: Optional[str] = None
+    sid: Optional[str] = None
+    schema_: Optional[str] = Field(None, alias="schema")
+
+    def model_post_init(self, __context):
+        if not self.service_name and not self.sid:
+            raise ValueError("Either 'service_name' or 'sid' must be provided.")
+
+
+class OracleConfig(SchemaBase):
+    identifier: str
+    type: Literal["oracle"] = "oracle"