Skip to content

Harden external-PR workflows and restrict command triggers #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
e271828- merged 5 commits into from
Mar 2, 2026
Merged

Harden external-PR workflows and restrict command triggers #3

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b175c71
Harden external PR workflows against token abuse
e271828- Mar 2, 2026
f349c71
Apply suggestion from @e271828-
e271828- Mar 2, 2026
943718e
Apply suggestion from @e271828-
e271828- Mar 2, 2026
978b232
Apply suggestion from @e271828-
e271828- Mar 2, 2026
e2ebec7
Apply suggestion from @e271828-
e271828- Mar 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/e2e-external-phase-1.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,9 @@ jobs:
# If reviewed by a repo(/org) owner
if: |
github.event.pull_request.author_association != 'MEMBER'
&& github.event.review.author_association == 'MEMBER'
&& (
contains(fromJson('["OWNER", "MEMBER", "COLLABORATOR"]'), github.event.review.author_association)
Comment thread
e271828- marked this conversation as resolved.
Outdated
)
&& github.event.review.state == 'approved'
&& contains(github.event.review.body, '/e2e')
runs-on: ubuntu-latest
Expand Down
4 changes: 0 additions & 4 deletions .github/workflows/e2e-external-phase-2.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,10 +83,6 @@ jobs:

- name: Checkout
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
with:
# Important: use the commit that was reviewed. GitHub is making sure
# that this is race-condition-proof
ref: ${{ steps.extract_commit.outputs.COMMIT_ID }}

- name: Install uv
uses: astral-sh/setup-uv@0c5e2b8115b80b4c7c5ddf6ffdd634974642d182 # v5.4.1
Expand Down
8 changes: 8 additions & 0 deletions .github/workflows/e2e-private-link-in-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@ jobs:
if: |
github.event.issue.pull_request
&& contains(github.event.comment.body, '/invite')
&& (
contains(fromJson('["OWNER", "MEMBER", "COLLABORATOR"]'), github.event.comment.author_association)
|| contains(fromJson('["kieferro", "ewjoachim"]'), github.event.comment.user.login)
Comment thread
e271828- marked this conversation as resolved.
Outdated
)
runs-on: ubuntu-latest
strategy:
matrix:
Expand Down Expand Up @@ -42,6 +46,10 @@ jobs:
if: |
github.event.issue.pull_request
&& contains(github.event.comment.body, '/invite')
&& (
contains(fromJson('["OWNER", "MEMBER", "COLLABORATOR"]'), github.event.comment.author_association)
|| contains(fromJson('["kieferro", "ewjoachim"]'), github.event.comment.user.login)
Comment thread
e271828- marked this conversation as resolved.
Outdated
)
runs-on: ubuntu-latest
permissions:
pull-requests: write
Expand Down
Loading