HIVE-29648: Split ObjectStore into modular TableStore and PrivilegeStore (apache#6450)

Author: dengzhhu653

itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/AbstractTestAuthorizationApiAuthorizer.java

@@ -86,11 +86,11 @@ private void testFunction(FunctionInvoker mscFunctionInvoker) throws Exception {
       } catch (RuntimeException e) {
         // A hack to verify that authorization check passed. Exception can be thrown be cause
         // the functions are not being called with valid params.
-        // verify that exception has come from ObjectStore code, which means that the
+        // verify that exception has come from RawStore code, which means that the
         // authorization checks passed.
         String exStackString = ExceptionUtils.getStackTrace(e);
         assertTrue("Verifying this exception came after authorization check",
-                exStackString.contains("org.apache.hadoop.hive.metastore.ObjectStore"));
+                exStackString.contains("org.apache.hadoop.hive.metastore.RawStore"));
         // If its not an exception caused by auth check, ignore it
       }
       assertFalse("Authz Exception should have been thrown in remote mode", isRemoteMetastoreMode);

ql/src/test/org/apache/hadoop/hive/ql/metadata/TestSessionHiveMetastoreClientAlterPartitionsTempTable.java

@@ -247,4 +247,15 @@ private void assertPartitionRollback(List<Partition> oldParts, List<Partition> a
     fail("Exception should have been thrown.");
   }
 
+  @Override
+  @Test(expected = MetaException.class)
+  public void testRenamePartitionChangeTblName() throws Exception {
+    super.testRenamePartitionChangeTblName();
+  }
+
+  @Override
+  @Test(expected = MetaException.class)
+  public void testRenamePartitionChangeDbName() throws Exception {
+    super.testRenamePartitionChangeDbName();
+  }
 }

ql/src/test/queries/clientpositive/partitions_filter_default.q

@@ -1,3 +1,4 @@
+--! qt:disabled:HIVE-25965
 
 create table ptestfilter (a string) partitioned by (c int);
 INSERT OVERWRITE TABLE ptestfilter PARTITION (c) select 'Col1', null;

standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java

@@ -3253,6 +3253,11 @@ public Function get_function(String dbName, String funcName) throws TException {
 
   @Override
   public void update_table_params(List<TableParamsUpdate> updates) throws TException {
+    for (TableParamsUpdate update : updates) {
+      if (!update.isSetCat_name()) {
+        update.setCat_name(getDefaultCatalog(conf));
+      }
+    }
     getMS().updateTableParams(updates);
   }
 

standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java

@@ -639,6 +639,18 @@ public Partition alterPartition(RawStore msdb, Warehouse wh, String catName, Str
     FileSystem destFs = null;
     boolean dataWasMoved = false;
     Database db;
+    Partition check_part;
+    try {
+      check_part = msdb.getPartition(catName, dbname, name, new_part.getValues());
+    } catch(NoSuchObjectException e) {
+      // this means there is no existing partition
+      check_part = null;
+    }
+
+    if (check_part != null) {
+      throw new AlreadyExistsException("Partition already exists:" + dbname + "." + name + "." +
+          new_part.getValues());
+    }
     try {
       msdb.openTransaction();
       Table tbl = msdb.getTable(catName, dbname, name, null);
@@ -655,19 +667,6 @@ public Partition alterPartition(RawStore msdb, Warehouse wh, String catName, Str
             "Unable to rename partition because old partition does not exist");
       }
 
-      Partition check_part;
-      try {
-        check_part = msdb.getPartition(catName, dbname, name, new_part.getValues());
-      } catch(NoSuchObjectException e) {
-        // this means there is no existing partition
-        check_part = null;
-      }
-
-      if (check_part != null) {
-        throw new AlreadyExistsException("Partition already exists:" + dbname + "." + name + "." +
-            new_part.getValues());
-      }
-
       // when renaming a partition, we should update
       // 1) partition SD Location
       // 2) partition column stats if there are any because of part_name field in HMS table PART_COL_STATS