ci: Try to run tests on pull request (Quenty#577)

* ci: Try to run tests on pull request

* ci: Tests do not say anything about funding

* fix: Try to lint on pull_request too

* ci: Rename lint -> linting because github is confused

Author: Quenty

.github/workflows/build.yml

@@ -1,16 +1,16 @@
 name: build
 on: [push]
 jobs:
-  lint:
-    uses: ./.github/workflows/lint.yml
+  build-linting:
+    uses: ./.github/workflows/linting.yml
 
   release:
-    needs: [lint]
+    needs: [build-linting]
     runs-on: ubuntu-latest
     if: "!contains(github.event.head_commit.message, 'ci skip') && !contains(github.event.head_commit.message, 'skip ci')"
     steps:
       - name: Checkout repository
-        uses: actions/checkout@v2
+        uses: actions/checkout@v4
         with:
           fetch-depth: 0
           persist-credentials: false # https://stackoverflow.com/questions/74744498/github-pushing-to-protected-branches-with-fine-grained-token
@@ -23,16 +23,16 @@ jobs:
           cache-dependency-path: package.json # we don't have a package-lock.json so we'll use this instead...
           node-version: '18'
 
-      - name: Run `npm install --no-package-lock` on cli-output-helpers
-        run: npm install --no-package-lock
+      - name: Run `npm install --no-package-lock --no-fund` on cli-output-helpers
+        run: npm install --no-package-lock --no-fund
         working-directory: tools/cli-output-helpers
 
       - name: Build cli-output-helpers
         run: npm run build
         working-directory: tools/cli-output-helpers
 
-      - name: Run `npm install --no-package-lock` on nevermore-template-helpers
-        run: npm install --no-package-lock
+      - name: Run `npm install --no-package-lock --no-fund` on nevermore-template-helpers
+        run: npm install --no-package-lock  --no-fund
         working-directory: tools/nevermore-template-helpers
 
       - name: Build nevermore-template-helpers
@@ -58,7 +58,7 @@ jobs:
         working-directory: tools/nevermore-cli
 
       - name: Run npm install
-        run: npm install --no-save
+        run: npm install --no-save --no-fund
 
       - name: Git reset .npmrc
         run: git checkout .npmrc

.github/workflows/docs.yml

@@ -9,7 +9,7 @@ jobs:
     name: Build and deploy docs
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
       - uses: actions/setup-node@v2
         with:
           node-version: '18'

.github/workflows/lint.yml .github/workflows/linting.yml.github/workflows/lint.yml renamed to .github/workflows/linting.yml

@@ -1,11 +1,11 @@
-name: lint
-on: [pull_request_target, workflow_call]
+name: linting
+on: [pull_request, workflow_call]
 jobs:
   luau-lsp:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout repository
-        uses: actions/checkout@v2
+        uses: actions/checkout@v4
 
       - name: Setup Aftman
         uses: ok-nick/setup-aftman@v0.4.2

.github/workflows/tests.yml

@@ -1,5 +1,5 @@
 name: tests
-on: [push]
+on: [pull_request]
 jobs:
   tests:
     runs-on: ubuntu-latest
@@ -33,7 +33,7 @@ jobs:
       - name: Install package dependencies
         run: |
           echo "Installing package dependencies..."
-          npx lerna exec -- npm install --no-audit
+          npx lerna exec -- npm install --no-audit --no-fund
           PACKAGES=$(npx lerna ls --since origin/main --json | jq -r '.[] | select(.name != "@quenty/nevermore-cli") | .location' | tr '\n' ' ')
           echo "PACKAGES=$PACKAGES" >> $GITHUB_ENV