Skip to content

Commit 76bea2d

Browse files
Copilotnielsdrost7
andcommitted
Address code review feedback: fix banner, Dockerfile improvements, workflow updates
Co-authored-by: nielsdrost7 <47660417+nielsdrost7@users.noreply.github.com>
1 parent d101f84 commit 76bea2d

10 files changed

Lines changed: 2001 additions & 43 deletions

File tree

.docker/invoiceplane-banner.sh

Lines changed: 3 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -24,21 +24,6 @@ show_logo() {
2424
EOF
2525
}
2626

27-
# Helper function to display container info box
28-
show_info_box() {
29-
local container_type="${1:-Unknown}"
30-
local user_name
31-
local host_name
32-
33-
user_name=$(whoami 2>/dev/null || echo "unknown")
34-
host_name=$(hostname 2>/dev/null || echo "unknown")
35-
36-
echo -e "${IPBLUE}╔════════════════════════════════════════════════════════════╗${NC}"
37-
echo -e "${IPBLUE}${NC} ${container_type}${IPBLUE}${NC}"
38-
echo -e "${IPBLUE}${NC} Container: ${GREEN}${host_name}${NC} | User: ${YELLOW}${user_name}${NC} | Dir: ${GREEN}\w${NC}${IPBLUE}${NC}"
39-
echo -e "${IPBLUE}╚════════════════════════════════════════════════════════════╝${NC}"
40-
}
41-
4227
# Helper function to show PHP version if available
4328
show_php_version() {
4429
if command -v php >/dev/null 2>&1; then
@@ -85,12 +70,12 @@ display_banner() {
8570
echo -e "${IPBLUE}╚════════════════════════════════════════════════════════════╝${NC}"
8671

8772
# Show additional info
88-
local user_name host_name pwd
73+
local user_name host_name current_dir
8974
user_name=$(whoami 2>/dev/null || echo "unknown")
9075
host_name=$(hostname 2>/dev/null || echo "unknown")
91-
pwd=$(pwd 2>/dev/null || echo "~")
76+
current_dir=$(pwd 2>/dev/null || echo "~")
9277

93-
echo -e "Container: ${GREEN}${host_name}${NC} | User: ${YELLOW}${user_name}${NC} | Dir: ${GREEN}${pwd}${NC}"
78+
echo -e "Container: ${GREEN}${host_name}${NC} | User: ${YELLOW}${user_name}${NC} | Dir: ${GREEN}${current_dir}${NC}"
9479

9580
# Display quick commands
9681
show_quick_commands

0 commit comments

Comments
 (0)