[IP-513]: duplicate-number prevention via Observers

[nielsdrost7]

Summary

• [Invoices] As a QA engineer, I want to verify invoice numbering is unique and sequential. #513 — InvoiceObserver.saving() now uses withoutGlobalScopes() so the duplicate-number check works in all contexts (unauthenticated, queued jobs, tests); exception message aligned to what tests expect
• [Quotes] As a QA engineer, I want to verify quote numbering is unique and sequential. #514 — QuoteObserver registered in QuotesServiceProvider.boot() (it was dead code before); uses withoutGlobalScopes(); plain string message replaces broken trans() call (no language file exists)
• Refactor — removed redundant booted()->creating hooks from Invoice and Quote models; Observer saving() already fires before creating and covers both create and update
• Docs — added Observer convention to CLAUDE.md: all model lifecycle logic goes in Observers/, never inline booted()

New tests: InvoiceDuplicateNumberPreventionTest, QuoteDuplicateNumberPreventionTest.

Closes

Closes #513 — invoice duplicate-number prevention via Observer, scope-safe check
Closes #514 — quote duplicate-number prevention; QuoteObserver actually wired up

Follow-up issues

None.

Test plan

• php artisan test --filter=InvoiceDuplicateNumberPreventionTest — duplicate invoice number throws expected exception
• php artisan test --filter=QuoteDuplicateNumberPreventionTest — duplicate quote number throws expected exception
• Verify no booted() method remains in Invoice.php or Quote.php

[coderabbitai]

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a9f764b3-373b-4d2e-8416-825e59dc45f5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feature/513-514-duplicate-prevention

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}