[IP-542]: invoice edit page#575
Draft
nielsdrost7 wants to merge 2 commits into
Draft
Conversation
…ctions (InvoicePlane#542, InvoicePlane#223, InvoicePlane#224, InvoicePlane#96, InvoicePlane#190, InvoicePlane#171) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
5a649ff to
6338343
Compare
This was referenced Jul 4, 2026
This was referenced Jul 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
InvoicesTablewith navigation to a dedicatedEditRecordpage (EditInvoice)editroute inInvoiceResource::getPages()Header actions
SENT,PAID,PARTIALLY_PAIDPAIDinvoices and read-only invoicesCloses
Closes #542 — EditInvoice page (parent)
Closes #223 — Invoice action bar: download PDF / send email
Closes #224 — Invoice action bar: create credit note / recurring / copy
Closes #96 — Preview an invoice PDF before emailing or printing
Closes #190 — Download PDF for an invoice from the invoice view
Closes #171 — Issue credit notes from invoices for refunds or adjustments
Follow-up issues (not resolved here — reopen if auto-closed on merge)
Closes #586 — Create Recurring Invoice stub (action bar still shows a "not yet implemented" toast; no RecurringInvoice creation flow wired up)
Closes #520 — Send Email stub (the "Email Invoice" action itself is tracked there; the wider email flow lives in #520–#527)
Test plan
DRAFTstatus → Credit Note action is hidden, Delete is visibleSENTstatus → Credit Note action is visible, Delete is visiblePAIDstatus → Credit Note is visible, Delete is hiddenDRAFTinvoice with all line items, redirects to its edit page<invoice-number>.pdfdownloadcreditinvoice_parent_id; attempting to credit a credit note is refused with a notificationUpdate 2026-07-04 — PDF preview/download + credit notes (#96, #190, #171)
domPDFdriver was missing itsDompdf\*imports and theip.pdfDriver/paperSize/paperOrientationconfig keys — now operational viaPDFFactory.invoices::pdf.invoiceBlade template — one document markup shared by the PDF driver and the on-screen preview.InvoiceService:renderHtml(),generatePdf()(StreamedResponse named<invoice-number>.pdf),createCreditNote()(negated draft,invoice_sign = -1, linked viacreditinvoice_parent_id, null number until it leaves draft; crediting a credit note refused).develop(permission-seeding test fix) and restored develop's modal EditAction on the invoices list — the list keeps the modal flow the develop suite asserts; the EditInvoice page remains for its route and redirects.Tests:
InvoicePdfAndCreditNoteTest(6) — full suite on this branch: 0 failed, 283 passed (baseline develop: 272 passed).