[IP-268]: bill project tasks#578
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
98e15f8 to
3bfd531
Compare
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughAdds a permission-gated project table action for selecting completed, unbilled tasks and adding them to a customer’s draft invoice. The billing service creates or reuses invoices, inserts task items, recalculates totals, and reports validation failures. Feature tests cover billing and task eligibility. ChangesProject task billing
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
actor User
participant ProjectsTable
participant ProjectBillingService
participant DraftInvoice
participant InvoiceItem
User->>ProjectsTable: Select completed tasks
ProjectsTable->>ProjectBillingService: billTasks(project, taskIds)
ProjectBillingService->>DraftInvoice: Find or create draft invoice
ProjectBillingService->>InvoiceItem: Add task invoice items
ProjectBillingService->>DraftInvoice: Refresh totals
DraftInvoice-->>ProjectsTable: Return invoice
ProjectsTable-->>User: Show billing notification
Possibly related PRs
Suggested reviewers: ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
# Conflicts: # .gitignore # Modules/Quotes/Tests/Feature/QuotesTest.php
What
ProjectBillingService::billTasks(Project, array $taskIds): Invoice— creates one invoice item per selected task (item name = task name, quantity 1, price =task_price, task's tax rate,task_idlink). Appends to the client's existing draft invoice when one exists, otherwise creates a new draft with a null invoice number (numbering is assigned when the invoice leaves draft — consistent with the duplicate-prevention observer on PR [IP-513]: duplicate-number prevention via Observers #540, which allows multiple nulls for drafts).invoice_items.task_id) qualify — double billing is impossible.create-invoices) opens a checkbox list of billable tasks; guard failures surface as a notification.Deviation from the SMART plan: no redirect to
EditInvoiceafter billing — that page didn't exist on develop when this PR was written. It does now (and is further extended by PR #575), so the redirect is a ready-to-do follow-up (#587).Closes
Closes #268 — Convert project tasks to invoice items for billing
Follow-up issues (not resolved here — reopen if auto-closed on merge)
Closes #587 — No redirect to the invoice edit page after billing project tasks (action only shows a success toast; now unblocked since
EditInvoiceexists on develop)Tests
ProjectBillingTest— 5 tests: new draft creation, append-to-existing-draft, double-billing rejection, non-completed rejection, and modal option filtering.Summary by CodeRabbit