Feature/543 quote edit page#576
Draft
nielsdrost7 wants to merge 26 commits into
Draft
Conversation
…us-aware header actions Replaces inline modal edit in QuotesTable with navigation to a dedicated EditRecord page. Header actions include download PDF, send email, convert to invoice, copy quote (via QuoteService::duplicateQuote), and a conditional DeleteAction hidden for approved/rejected quotes. Closes InvoicePlane#543, InvoicePlane#222 https://claude.ai/code/session_01L9apN3AW7b5h7ypmBA5pUg
Resource pages gate on Spatie permissions since the role-permissions feature (InvoicePlane#500), but the test base classes never seeded them, so every company/admin panel Livewire test aborted with 403. Seed permissions and roles in setUp and assign client_admin / super_admin to the test users. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Resolve QuotesTable conflict: keep page-based EditAction (routes to the new EditQuote page) with develop's EDIT_QUOTES permission gate, and keep develop's new row actions (duplicate, pdf, email, print, mark_sent, approve, reject, convert_to_invoice, archive). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
All actions visible on draft. Delete hidden for approved and rejected quotes. Copy action duplicates the quote as a new unnumbered draft. Seeds Spatie permissions in setUp so the page mounts regardless of the base-class seeding fix shipping upstream. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Adopt develop's modal EditAction on the quotes list — the develop test suite asserts the modal flow; the EditQuote page stays for its route and redirects. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
QuotesTablewith navigation to a dedicatedEditRecordpage (EditQuote)editroute inQuoteResource::getPages()Header actions
QuoteService::duplicateQuote(), redirects to new edit pageAPPROVEDandREJECTEDquotesCloses
Test plan
DRAFTstatus → Delete is visibleAPPROVEDstatus → Delete is hiddenREJECTEDstatus → Delete is hidden