IronPython.modules.misc.test_zlib is not parallel safe

[slozier]

Running make.ps1 test-zlib can fail with:

FileNotFoundError: [WinError 2] The system cannot find the file specified: 'test_data.gz'

The test should be made parallel safe or add NotParallelSafe=true if not possible.

[tiffanyelangwa]

Hi! I'm Tiffany, a student taking CodePath's AI301 course, where one of our assignments is to make an open-source contribution. I came across this issue and it seems like a great fit for my skill level and interests. Is it still open? If so, I'd love to work on it.

[slozier]

Hi! I'm Tiffany, a student taking CodePath's AI301 course, where one of our assignments is to make an open-source contribution. I came across this issue and it seems like a great fit for my skill level and interests. Is it still open? If so, I'd love to work on it.

Hi Tiffany, thanks for the interest. It looks like the concurrency issue was resolved by #2002. However, now that the test is parallel safe the NotParallelSafe=true setting that was added in #1397 could be removed if you're interested. Though maybe that change is too simple for an assignment? 😄

[tiffanyelangwa]

Hi! I'm Tiffany, a student taking CodePath's AI301 course, where one of our assignments is to make an open-source contribution. I came across this issue and it seems like a great fit for my skill level and interests. Is it still open? If so, I'd love to work on it.

Hi Tiffany, thanks for the interest. It looks like the concurrency issue was resolved by #2002. However, now that the test is parallel safe the NotParallelSafe=true setting that was added in #1397 could be removed if you're interested. Though maybe that change is too simple for an assignment? 😄

Thanks for the clarification! I agree that simply removing NotParallelSafe=true might be a bit small for the assignment, but I'd still be interested in investigating whether the flag is truly obsolete. I'll take a look at #1397 and #2002, verify that the tests run correctly in parallel without the flag, and if everything checks out, I may open a small cleanup PR.