using correct find object way for the in app test

Author: franco-zalamena-iterable

integration-tests/src/androidTest/java/com/iterable/integration/tests/InAppMessageIntegrationTest.kt

@@ -11,9 +11,9 @@ import androidx.test.ext.junit.runners.AndroidJUnit4
 import androidx.test.platform.app.InstrumentationRegistry
 import androidx.test.runner.lifecycle.ActivityLifecycleMonitorRegistry
 import androidx.test.runner.lifecycle.Stage
-import androidx.test.uiautomator.UiDevice
-import androidx.test.uiautomator.UiSelector
 import androidx.test.uiautomator.By
+import androidx.test.uiautomator.UiDevice
+import androidx.test.uiautomator.Until
 import com.iterable.iterableapi.IterableApi
 import com.iterable.iterableapi.IterableInAppMessage
 import com.iterable.iterableapi.IterableInAppLocation
@@ -38,6 +38,10 @@ class InAppMessageIntegrationTest : BaseIntegrationTest() {
         private const val TAG = "InAppMessageIntegrationTest"
         private const val TEST_CAMPAIGN_ID = TestConstants.TEST_INAPP_CAMPAIGN_ID
         private const val TEST_EVENT_NAME = "test_inapp_event"
+
+        // SDK-170: ample wait so a slow CI emulator (SurfaceSyncGroup timeouts in logs) can
+        // finish drawing MainActivity before we look for the button. Local cost: 0 (passes fast).
+        private const val BTN_IN_APP_TIMEOUT_MS = 30_000L
     }
 
     private lateinit var uiDevice: UiDevice
@@ -100,16 +104,22 @@ class InAppMessageIntegrationTest : BaseIntegrationTest() {
 
         Log.d(TAG, "🔧 MainActivity is ready!")
 
-        // Step 2: Click the "In-App Messages" button to navigate to InAppMessageTestActivity
-        Log.d(TAG, "🔧 Step 2: Clicking 'In-App Messages' button...")
-        val inAppButton = uiDevice.findObject(UiSelector().resourceId("com.iterable.integration.tests:id/btnInAppMessages"))
-        if (inAppButton.exists()) {
+        // Step 2: Click the "In-App Messages" button to navigate to InAppMessageTestActivity.
+        // SDK-170: Lifecycle.RESUMED does not guarantee the layout is drawn — under CI load
+        // (SurfaceSyncGroup transaction-ready timeouts), `findObject(...).exists()` ran ~2s
+        // after RESUMED and returned false because the button view was not yet present in the
+        // accessibility tree. `uiDevice.wait(Until.findObject(...))` polls until the node
+        // appears or the timeout elapses.
+        Log.d(TAG, "🔧 Step 2: Waiting for and clicking 'In-App Messages' button...")
+        val inAppButton = uiDevice.wait(
+            Until.findObject(By.res("com.iterable.integration.tests", "btnInAppMessages")),
+            BTN_IN_APP_TIMEOUT_MS
+        )
+        if (inAppButton != null) {
             inAppButton.click()
             Log.d(TAG, "🔧 Clicked In-App Messages button successfully")
         } else {
-            //Take screenshot for debugging
-//            uiDevice.takeScreenshot(File("/sdcard/Download/InAppButtonNotFound.png"))
-            Log.e(TAG, "❌ In-App Messages button not found!")
+            Log.e(TAG, "❌ In-App Messages button not found within ${BTN_IN_APP_TIMEOUT_MS}ms (current package: ${uiDevice.currentPackageName})")
             Assert.fail("In-App Messages button not found in MainActivity")
         }