Skip to content

Reverting the changes causing release block#897

Merged
Ayyanchira merged 1 commit into
masterfrom
chore/reverting-maven-push
Apr 3, 2025
Merged

Reverting the changes causing release block#897
Ayyanchira merged 1 commit into
masterfrom
chore/reverting-maven-push

Conversation

@Ayyanchira
Copy link
Copy Markdown
Member

🔹 Jira Ticket(s) if any

✏️ Description

Please provide a brief description of what this pull request does.

@Ayyanchira Ayyanchira requested review from Copilot and evantk91 April 3, 2025 11:49
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reverts changes that were previously causing a release block by modifying the GPG key import process and adjusting Gradle command flags for building and publishing.

  • Reverts GPG key import steps to use a temporary file for importing the key instead of direct import
  • Removes the verbose Gradle flags (--info and --build-cache) from build and publish commands
  • Introduces the ORG_GRADLE_PROJECT_SIGNING_SECRET_KEY_RING_FILE environment variable in both the Build and Publish steps
Files not reviewed (1)
  • maven-push.gradle: Language not supported
Comments suppressed due to low confidence (1)

.github/workflows/publish.yml:42

  • Similar to the Build step, the Publish step references ~/.gnupg/secring.gpg which may not be generated by the revised GPG import process. Ensure that the key ring file exists at the specified location or adjust the import process accordingly.
ORG_GRADLE_PROJECT_SIGNING_SECRET_KEY_RING_FILE: ~/.gnupg/secring.gpg

env:
ORG_GRADLE_PROJECT_SIGNING_KEY_ID: ${{ secrets.SIGNING_KEY_ID }}
ORG_GRADLE_PROJECT_SIGNING_PASSWORD: ${{ secrets.SIGNING_PASSWORD }}
ORG_GRADLE_PROJECT_SIGNING_SECRET_KEY_RING_FILE: ~/.gnupg/secring.gpg
Copy link

Copilot AI Apr 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The environment variable ORG_GRADLE_PROJECT_SIGNING_SECRET_KEY_RING_FILE is set to ~/.gnupg/secring.gpg, but the new GPG import step does not create or ensure the existence of this file. Consider updating the GPG import process to either generate the expected key ring file or modifying the environment variable to match the actual file location.

Copilot uses AI. Check for mistakes.
@Ayyanchira Ayyanchira merged commit 03f1b01 into master Apr 3, 2025
3 checks passed
@Ayyanchira Ayyanchira deleted the chore/reverting-maven-push branch April 3, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants