Reverting the changes causing release block#897
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR reverts changes that were previously causing a release block by modifying the GPG key import process and adjusting Gradle command flags for building and publishing.
- Reverts GPG key import steps to use a temporary file for importing the key instead of direct import
- Removes the verbose Gradle flags (--info and --build-cache) from build and publish commands
- Introduces the ORG_GRADLE_PROJECT_SIGNING_SECRET_KEY_RING_FILE environment variable in both the Build and Publish steps
Files not reviewed (1)
- maven-push.gradle: Language not supported
Comments suppressed due to low confidence (1)
.github/workflows/publish.yml:42
- Similar to the Build step, the Publish step references ~/.gnupg/secring.gpg which may not be generated by the revised GPG import process. Ensure that the key ring file exists at the specified location or adjust the import process accordingly.
ORG_GRADLE_PROJECT_SIGNING_SECRET_KEY_RING_FILE: ~/.gnupg/secring.gpg
| env: | ||
| ORG_GRADLE_PROJECT_SIGNING_KEY_ID: ${{ secrets.SIGNING_KEY_ID }} | ||
| ORG_GRADLE_PROJECT_SIGNING_PASSWORD: ${{ secrets.SIGNING_PASSWORD }} | ||
| ORG_GRADLE_PROJECT_SIGNING_SECRET_KEY_RING_FILE: ~/.gnupg/secring.gpg |
There was a problem hiding this comment.
The environment variable ORG_GRADLE_PROJECT_SIGNING_SECRET_KEY_RING_FILE is set to ~/.gnupg/secring.gpg, but the new GPG import step does not create or ensure the existence of this file. Consider updating the GPG import process to either generate the expected key ring file or modifying the environment variable to match the actual file location.
evantk91
approved these changes
Apr 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔹 Jira Ticket(s) if any
✏️ Description