diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index af70363b..cb9846c5 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -1,32 +1,4 @@ -# This is a CODEOWNERS file. It defines who is responsible for different parts of the codebase. -# See: https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners +# https://docs.github.com/articles/about-code-owners +# Require review from the SDK team on every PR. -# These owners will be the default owners for everything in the repo. -# Unless a later match takes precedence, they will be requested for review when someone opens a pull request. -* @Iterable/mobile - -# Plugin source code -/plugin/ @Iterable/mobile - -# Runtime code -/src/ @Iterable/mobile - -# Example app -/example/ @Iterable/mobile - -# Configuration files -/.github/ @Iterable/mobile -/tsconfig.json @Iterable/mobile -/.eslintrc.js @Iterable/mobile -/.prettierrc @Iterable/mobile -/.editorconfig @Iterable/mobile -/.nvmrc @Iterable/mobile - -# Documentation -/README.md @Iterable/mobile -/CHANGELOG.md @Iterable/mobile -/LICENSE @Iterable/mobile - -# Build and test configuration -/jest.config.js @Iterable/mobile -/expo-module.config.json @Iterable/mobile +* @Iterable/sdk-team diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index c710f4f7..b7186b26 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,23 +1,19 @@ -## ๐ŸŽŸ๏ธ JIRA ticket(s) +# ๐Ÿ“ Summary +> _This should be a 150 characters summary of the changes on this PR_ -- [MOB-1234](https://iterable.atlassian.net/browse/MOB-1234) +###### ๐ŸŽŸ๏ธ Jira Ticket: [SDK-XXXX](https://iterable.atlassian.net/browse/SDK-XXXX) -## ๐Ÿ• Description +## ๐Ÿ“– Description +> Please provide a description of what this pull request does. -Please explain the changes you made +## ๐Ÿงช How to test? +> How to test the changes added? -## ๐Ÿ“ท Screenshots +## ๐Ÿ“น Loom recording if applicable +> If it helps the reviewer, add a short Loom going over the changes or showcasing the change in behavior. -Screenshots if the PR has visual changes. +#### ๐Ÿž Github Issues solved +> If this solves any open GH Issues, please link them here. -| android | ios | -| ------------------ | -------------- | -| ANDROID_SCREENSHOT | IOS_SCREENSHOT | - -## ๐Ÿง Testing - -Please explain the steps needed to verify your change. - -## ๐Ÿ“ Documentation - -How have you documented these changes? +#### ๐Ÿ“š Docs PR if applicable +> Open a PR on the [Docs Repo](https://github.com/Iterable/iterable-docs) documenting the changes.