From c9a7a3b95095fd4c6f009bf8be569a5b1347b0fb Mon Sep 17 00:00:00 2001 From: Joao Dordio Date: Fri, 17 Jul 2026 14:08:52 +0100 Subject: [PATCH 1/2] chore: adopt shared SDK PR template and auto-request sdk-team reviews - Replace PR template with the shared SDK template - Add workflow to request review from @Iterable/sdk-team on new PRs - Remove CODEOWNERS in favor of the reviewer workflow --- .github/CODEOWNERS | 32 -------------------------- .github/pull_request_template.md | 30 +++++++++++------------- .github/workflows/assign-reviewers.yml | 27 ++++++++++++++++++++++ 3 files changed, 40 insertions(+), 49 deletions(-) delete mode 100644 .github/CODEOWNERS create mode 100644 .github/workflows/assign-reviewers.yml diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS deleted file mode 100644 index af70363b..00000000 --- a/.github/CODEOWNERS +++ /dev/null @@ -1,32 +0,0 @@ -# This is a CODEOWNERS file. It defines who is responsible for different parts of the codebase. -# See: https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners - -# These owners will be the default owners for everything in the repo. -# Unless a later match takes precedence, they will be requested for review when someone opens a pull request. -* @Iterable/mobile - -# Plugin source code -/plugin/ @Iterable/mobile - -# Runtime code -/src/ @Iterable/mobile - -# Example app -/example/ @Iterable/mobile - -# Configuration files -/.github/ @Iterable/mobile -/tsconfig.json @Iterable/mobile -/.eslintrc.js @Iterable/mobile -/.prettierrc @Iterable/mobile -/.editorconfig @Iterable/mobile -/.nvmrc @Iterable/mobile - -# Documentation -/README.md @Iterable/mobile -/CHANGELOG.md @Iterable/mobile -/LICENSE @Iterable/mobile - -# Build and test configuration -/jest.config.js @Iterable/mobile -/expo-module.config.json @Iterable/mobile diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index c710f4f7..b7186b26 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,23 +1,19 @@ -## ๐ŸŽŸ๏ธ JIRA ticket(s) +# ๐Ÿ“ Summary +> _This should be a 150 characters summary of the changes on this PR_ -- [MOB-1234](https://iterable.atlassian.net/browse/MOB-1234) +###### ๐ŸŽŸ๏ธ Jira Ticket: [SDK-XXXX](https://iterable.atlassian.net/browse/SDK-XXXX) -## ๐Ÿ• Description +## ๐Ÿ“– Description +> Please provide a description of what this pull request does. -Please explain the changes you made +## ๐Ÿงช How to test? +> How to test the changes added? -## ๐Ÿ“ท Screenshots +## ๐Ÿ“น Loom recording if applicable +> If it helps the reviewer, add a short Loom going over the changes or showcasing the change in behavior. -Screenshots if the PR has visual changes. +#### ๐Ÿž Github Issues solved +> If this solves any open GH Issues, please link them here. -| android | ios | -| ------------------ | -------------- | -| ANDROID_SCREENSHOT | IOS_SCREENSHOT | - -## ๐Ÿง Testing - -Please explain the steps needed to verify your change. - -## ๐Ÿ“ Documentation - -How have you documented these changes? +#### ๐Ÿ“š Docs PR if applicable +> Open a PR on the [Docs Repo](https://github.com/Iterable/iterable-docs) documenting the changes. diff --git a/.github/workflows/assign-reviewers.yml b/.github/workflows/assign-reviewers.yml new file mode 100644 index 00000000..4051e256 --- /dev/null +++ b/.github/workflows/assign-reviewers.yml @@ -0,0 +1,27 @@ +name: Assign SDK Team Reviewers + +on: + pull_request: + types: [opened, ready_for_review] + +permissions: + pull-requests: write + +jobs: + assign-reviewers: + if: github.event.pull_request.draft == false + runs-on: ubuntu-latest + steps: + - uses: actions/github-script@v7 + with: + script: | + try { + await github.rest.pulls.requestReviewers({ + owner: context.repo.owner, + repo: context.repo.repo, + pull_number: context.payload.pull_request.number, + team_reviewers: ['sdk-team'], + }); + } catch (error) { + core.warning(`Failed to request sdk-team review: ${error.message}`); + } From a2be740e8e4c36f9f70fc3ad47d52e52c84c85c8 Mon Sep 17 00:00:00 2001 From: Joao Dordio Date: Fri, 17 Jul 2026 14:19:40 +0100 Subject: [PATCH 2/2] chore: require sdk-team review via CODEOWNERS instead of workflow --- .github/CODEOWNERS | 4 ++++ .github/workflows/assign-reviewers.yml | 27 -------------------------- 2 files changed, 4 insertions(+), 27 deletions(-) create mode 100644 .github/CODEOWNERS delete mode 100644 .github/workflows/assign-reviewers.yml diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS new file mode 100644 index 00000000..cb9846c5 --- /dev/null +++ b/.github/CODEOWNERS @@ -0,0 +1,4 @@ +# https://docs.github.com/articles/about-code-owners +# Require review from the SDK team on every PR. + +* @Iterable/sdk-team diff --git a/.github/workflows/assign-reviewers.yml b/.github/workflows/assign-reviewers.yml deleted file mode 100644 index 4051e256..00000000 --- a/.github/workflows/assign-reviewers.yml +++ /dev/null @@ -1,27 +0,0 @@ -name: Assign SDK Team Reviewers - -on: - pull_request: - types: [opened, ready_for_review] - -permissions: - pull-requests: write - -jobs: - assign-reviewers: - if: github.event.pull_request.draft == false - runs-on: ubuntu-latest - steps: - - uses: actions/github-script@v7 - with: - script: | - try { - await github.rest.pulls.requestReviewers({ - owner: context.repo.owner, - repo: context.repo.repo, - pull_number: context.payload.pull_request.number, - team_reviewers: ['sdk-team'], - }); - } catch (error) { - core.warning(`Failed to request sdk-team review: ${error.message}`); - }