SDK-33 inAppDisplayDelegate not displaying in-apps as expected (#1013)

Author: joaodordio

swift-sdk/Internal/in-app/InAppManager.swift

@@ -233,7 +233,9 @@ class InAppManager: NSObject, IterableInternalInAppManagerProtocol {
         if waitTime <= 0 {
             _ = scheduleSync()
         } else {
-            ITBInfo("can't sync now, need to wait: \(waitTime)")
+            ITBInfo("skipping sync (cooldown: \(waitTime)s), processing existing messages")
+            
+            processExistingMessages()
         }
     }
 
@@ -369,6 +371,15 @@ class InAppManager: NSObject, IterableInternalInAppManagerProtocol {
         }
     }
 
+    private func processExistingMessages() {
+        _ = InAppManager.getAppIsReady(applicationStateProvider: applicationStateProvider, displayer: displayer).map { [weak self] appIsActive in
+            if appIsActive, let messagesMap = self?.messagesMap {
+                self?.processAndShowMessage(messagesMap: messagesMap)
+                self?.persister.persist(messagesMap.values)
+            }
+        }
+    }
+    
     // This method schedules next triggered message after showing a message
     private func scheduleNextInAppMessage() {
         ITBDebug()
@@ -381,14 +392,7 @@ class InAppManager: NSObject, IterableInternalInAppManagerProtocol {
                 self?.scheduleNextInAppMessage()
             }
         } else {
-            _ = InAppManager.getAppIsReady(applicationStateProvider: applicationStateProvider, displayer: displayer).map { [weak self] appIsActive in
-                if appIsActive {
-                    if let messagesMap = self?.messagesMap {
-                        self?.processAndShowMessage(messagesMap: messagesMap)
-                        self?.persister.persist(messagesMap.values)
-                    }
-                }
-            }
+            processExistingMessages()
         }
     }
 

tests/unit-tests/InAppTests.swift

@@ -777,6 +777,56 @@ class InAppTests: XCTestCase {
         wait(for: [expectation4], timeout: testExpectationTimeout)
     }
 
+    func testShowBackgroundSyncedMessageOnForegroundWithinCooldown() {
+        let expectation1 = expectation(description: "initial sync completes")
+        let expectation2 = expectation(description: "background sync completes")
+        let expectation3 = expectation(description: "message shown on foreground within cooldown")
+        
+        let payload = TestInAppPayloadGenerator.createPayloadWithUrl(numMessages: 1)
+        
+        let mockInAppFetcher = MockInAppFetcher()
+        let mockDateProvider = MockDateProvider()
+        
+        let mockInAppDisplayer = MockInAppDisplayer()
+        mockInAppDisplayer.onShow.onSuccess { _ in
+            expectation3.fulfill()
+        }
+        
+        let config = IterableConfig()
+        config.inAppDisplayInterval = 1.0
+        
+        let mockApplicationStateProvider = MockApplicationStateProvider(applicationState: .active)
+        let mockNotificationCenter = MockNotificationCenter()
+        
+        let internalApi = InternalIterableAPI.initializeForTesting(
+            config: config,
+            dateProvider: mockDateProvider,
+            inAppFetcher: mockInAppFetcher,
+            inAppDisplayer: mockInAppDisplayer,
+            applicationStateProvider: mockApplicationStateProvider,
+            notificationCenter: mockNotificationCenter
+        )
+        
+        // 1. Initial sync with no messages (sets lastSyncTime)
+        mockInAppFetcher.mockMessagesAvailableFromServer(internalApi: internalApi, messages: []).onSuccess { _ in
+            expectation1.fulfill()
+        }
+        wait(for: [expectation1], timeout: testExpectationTimeout)
+        
+        // 2. App goes to background, new message arrives via background sync
+        mockApplicationStateProvider.applicationState = .background
+        mockInAppFetcher.mockInAppPayloadFromServer(internalApi: internalApi, payload).onSuccess { _ in
+            expectation2.fulfill()
+        }
+        wait(for: [expectation2], timeout: testExpectationTimeout)
+        
+        // 3. App returns to foreground within cooldown (no time advance)
+        mockApplicationStateProvider.applicationState = .active
+        mockNotificationCenter.post(name: UIApplication.didBecomeActiveNotification, object: nil, userInfo: nil)
+        
+        wait(for: [expectation3], timeout: testExpectationTimeout)
+    }
+    
     func testDontShowNewlyArrivedMessageWithinRetryInterval() {
         let expectation1 = expectation(description: "show first message")
         let expectation2 = expectation(description: "don't show second message within interval")