SDK-99 Add async/await variants for disablePush#1067
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1067 +/- ##
==========================================
+ Coverage 71.42% 71.54% +0.11%
==========================================
Files 113 113
Lines 9410 9438 +28
==========================================
+ Hits 6721 6752 +31
+ Misses 2689 2686 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Does iOS have changelog entries only on the release or should we add it in this pr? |
franco-zalamena-iterable
approved these changes
May 29, 2026
Adds Swift concurrency overloads for the disablePush APIs: - disableDeviceForCurrentUser() async throws - disableDeviceForAllUsers() async throws Both are availability-gated (@available iOS 13 / macOS 10.15 / tvOS 13 / watchOS 6) and @nonobjc, so the existing parameterless and completion-handler methods — and the Obj-C surface — are unchanged. Each overload wraps the existing completion-handler API via withCheckedThrowingContinuation, throwing the public SendRequestError on failure (carrying the reason/data from OnFailureHandler). A small NSLock-backed resume-once guard prevents double-resume, and an explicit preflight throws "Iterable SDK is not initialized" rather than creating a continuation that would hang on the existing silent not-initialized path. The disablePush offline-retry user story shipped separately under SDK-297, and registerDevice retry is tracked in SDK-108; this ticket was rescoped to the async/await wrappers only. Tests cover success (current + all users), failure throwing SendRequestError with the right reason/data, and the not-initialized throw (verifying it does not hang). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
joaodordio
force-pushed
the
fix/SDK-99-disablepush-async-await
branch
from
bbb29b9 to
2e21d39
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds Swift concurrency overloads for the disablePush APIs so callers can
awaitthem. This was the only remaining piece of SDK-99 after offline-retry (SDK-297) and the success/fail callbacks already shipped.Changes
disableDeviceForCurrentUser() async throwsanddisableDeviceForAllUsers() async throwsonIterableAPI, wrapping the existing completion-handler APIs viawithCheckedThrowingContinuation.SendRequestErroron failure (carries the reason/data fromOnFailureHandler); anNSLock-backed guard makes resume exactly-once."Iterable SDK is not initialized"instead of hanging theawaiton the existing silent not-initialized path (the completion methods call neither handler when uninitialized).@available(iOS 13.0, macOS 10.15, tvOS 13.0, watchOS 6.0, *)+@nonobjcso existing methods and the Obj-C surface stay untouched (base target remains iOS 10).Impact
Testing
How to test:
./agent_build.sh(succeeds) and./agent_test.sh(unit 605 / notification-extension 12 / offline-events 90, 0 failures).IterableAPI.initialize…:try await IterableAPI.disableDeviceForCurrentUser()→ adisableDevicerequest is sent with the token.SendRequestErrorcarrying the response reason/data."Iterable SDK is not initialized"and does not hang.Jira: https://iterable.atlassian.net/browse/SDK-99