Skip to content

[MOB-11616] Resolve Remaining Vulnerable Security Dependencies #507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pauljung14 wants to merge 5 commits into from
Closed

[MOB-11616] Resolve Remaining Vulnerable Security Dependencies #507

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
918a269
[MOB-11616] Resolve braces vulnerability
pauljung14 Jun 16, 2025
c16beec
[MOB-11616] Upgrade @babel/preset-env
pauljung14 Jun 16, 2025
c503c24
[MOB-11616] Upgrade concurrently
pauljung14 Jun 16, 2025
4a2e223
[MOB-11616] Upgrade yup
pauljung14 Jun 16, 2025
6f32ebf
[MOB-11616] Upgrade madge and dedupe lockfile
pauljung14 Jun 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions example/yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1598,20 +1598,13 @@ brace-expansion@^1.1.7:
balanced-match "^1.0.0"
concat-map "0.0.1"

braces@^3.0.3:
braces@^3.0.3, braces@~3.0.2:
version "3.0.3"
resolved "https://registry.yarnpkg.com/braces/-/braces-3.0.3.tgz#490332f40919452272d55a8480adc0c441358789"
integrity sha512-yQbXgO/OSZVD2IsiLlro+7Hf6Q18EJrKSEsdoMzKePKXct3gvD8oLcOQdIzGupr5Fj+EDe8gO/lxc1BzfMpxvA==
dependencies:
fill-range "^7.1.1"

braces@~3.0.2:
version "3.0.2"
resolved "https://registry.yarnpkg.com/braces/-/braces-3.0.2.tgz#3454e1a462ee8d599e236df336cd9ea4f8afe107"
integrity sha512-b8um+L1RzM3WDSzvhm6gIz1yfTbBt6YTlcEKAvsmqCZZFw46z626lVj9j1yEPW33H5H+lBQpZMP1k8l+78Ha0A==
dependencies:
fill-range "^7.0.1"

browser-process-hrtime@^1.0.0:
version "1.0.0"
resolved "https://registry.yarnpkg.com/browser-process-hrtime/-/browser-process-hrtime-1.0.0.tgz#3c9b4b7d782c8121e56f10106d84c0d0ffc94626"
Expand Down Expand Up @@ -2592,7 +2585,7 @@ file-entry-cache@^6.0.1:
dependencies:
flat-cache "^3.0.4"

fill-range@^7.0.1, fill-range@^7.1.1:
fill-range@^7.1.1:
version "7.1.1"
resolved "https://registry.yarnpkg.com/fill-range/-/fill-range-7.1.1.tgz#44265d3cac07e3ea7dc247516380643754a05292"
integrity sha512-YsGpe3WHLK8ZYi4tWDg2Jy3ebRz2rXowDxnld4bkQB00cc/1Zw9AWnC0i9ztDJitivtQvaI9KaLyKrc+hBW0yg==
Expand Down
8 changes: 4 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
"qs": "^6.12.3",
"throttle-debounce": "^3.0.1",
"uuid": "^9.0.0",
"yup": "^0.32.9"
"yup": "^1.6.1"
},
"scripts": {
"start": "concurrently \"ttsc -w\" \"babel src --watch --out-dir ./dist --extensions '.ts,.tsx'\" \"webpack-dev-server --config webpack.dev.config.js\" -n 'tsc,babel,webpack' -k",
Expand All @@ -69,7 +69,7 @@
"@babel/plugin-transform-modules-umd": "^7.14.5",
"@babel/plugin-transform-nullish-coalescing-operator": "^7.23.4",
"@babel/plugin-transform-runtime": "^7.22.15",
"@babel/preset-env": "^7.5.5",
"@babel/preset-env": "^7.27.2",
"@babel/preset-typescript": "^7.6.0",
"@types/jest": "^27.0.2",
"@types/node": "^12.7.1",
Expand All @@ -80,7 +80,7 @@
"@webpack-cli/serve": "^1.6.0",
"babel-loader": "^9.1.3",
"babel-plugin-module-resolver": "^5.0.0",
"concurrently": "^6.3.0",
"concurrently": "^9.1.2",
"css-loader": "^6.8.1",
"dotenv": "^10.0.0",
"eslint": "^8.2.0",
Expand All @@ -93,7 +93,7 @@
"husky": "^3.1.0",
"jest": "^27.5.1",
"lint-staged": "^11.2.6",
"madge": "^5.0.1",
"madge": "^5.0.2",
"mini-css-extract-plugin": "^2.7.6",
"prettier": "^2.2.1",
"style-loader": "^3.3.3",
Expand Down
8 changes: 4 additions & 4 deletions src/inapp/inapp.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
/* eslint-disable consistent-return */
/* eslint-disable no-param-reassign */
/* eslint-disable no-redeclare */
import set from 'lodash/set';

@pauljung14 pauljung14 Jun 16, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@types/lodash was removed since the upgraded yup package didn't need it anymore, but doing so triggered import error here. Opted to just replace this with native js

import { throttle } from 'throttle-debounce';
import {
ABSOLUTE_DISMISS_BUTTON_ID,
Expand Down Expand Up @@ -670,9 +669,10 @@ export function getInAppMessages(
trackMessagesDelivered(messages || [], dupedPayload.packageName);
const withIframes = messages?.map((message) => {
const html = message.content?.html;
return html
? set(message, 'content.html', wrapWithIFrame(html as string))
: message;
if (html && message.content) {
message.content.html = wrapWithIFrame(html as string);
}
return message;
});
return {
...response,
Expand Down
Loading
Loading