Use IN set query for multi-element arrays

Single-element arrays still produce a simple term query.
Multi-element arrays now produce field:IN ["a" "b"] which maps
to tantivy's TermSetQuery — cleaner than chaining OR clauses.

Refs quickwit-oss/quickwit-datasource#179

Author: xrl

src/modifyQuery.test.ts

@@ -11,16 +11,16 @@ describe('addAddHocFilter', () => {
       expect(result).toBe('attributes.tags:paperclip');
     });
 
-    it('unwraps multi-element array into OR of term queries', () => {
+    it('unwraps multi-element array into IN set query', () => {
       const result = addAddHocFilter('', {
         key: 'attributes.tags',
         operator: '=',
         value: '["paperclip","stapler"]',
       });
-      expect(result).toBe('attributes.tags:paperclip OR attributes.tags:stapler');
+      expect(result).toBe('attributes.tags:IN ["paperclip" "stapler"]');
     });
 
-    it('negated array produces negated term queries', () => {
+    it('negated single-element array produces negated term query', () => {
       const result = addAddHocFilter('', {
         key: 'attributes.tags',
         operator: '!=',
@@ -29,6 +29,15 @@ describe('addAddHocFilter', () => {
       expect(result).toBe('-attributes.tags:paperclip');
     });
 
+    it('negated multi-element array produces negated IN set query', () => {
+      const result = addAddHocFilter('', {
+        key: 'attributes.tags',
+        operator: '!=',
+        value: '["paperclip","stapler"]',
+      });
+      expect(result).toBe('-attributes.tags:IN ["paperclip" "stapler"]');
+    });
+
     it('appends array filter to existing query with AND', () => {
       const result = addAddHocFilter('status:200', {
         key: 'attributes.tags',

src/modifyQuery.ts

@@ -40,9 +40,11 @@ export function addAddHocFilter(query: string, filter: AdHocVariableFilter): str
       }
       const modifier = filter.operator === '=' ? '' : '-';
       const key = escapeFilter(filter.key);
-      const termFilters = arrayElements.map((el) => `${modifier}${key}:${escapeFilterValue(el)}`);
-      const combined = termFilters.join(' OR ');
-      return concatenate(query, combined, 'AND');
+      if (arrayElements.length === 1) {
+        return concatenate(query, `${modifier}${key}:${escapeFilterValue(arrayElements[0])}`, 'AND');
+      }
+      const terms = arrayElements.map((el) => `"${escapeFilterValue(el)}"`).join(' ');
+      return concatenate(query, `${modifier}${key}:IN [${terms}]`, 'AND');
     }
     return LuceneQuery.parse(query).addFilter(filter.key, filter.value, filter.operator === '=' ? '' : '-').toString();
   }