Skip to content
This repository was archived by the owner on May 12, 2026. It is now read-only.

Commit d0e57a6

Browse files
hatemosphereclaude
andcommitted
test: update nested fields test for new id field and log message sort
Account for the synthetic `id` field (11 -> 12 fields) and for `logMessageField` now being sorted to position 1. Switch index-based assertions to name-based lookups so ordering changes don't break them. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 79efcf6 commit d0e57a6

1 file changed

Lines changed: 17 additions & 8 deletions

File tree

pkg/quickwit/response_parser_test.go

Lines changed: 17 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -253,22 +253,31 @@ func TestProcessLogsResponse(t *testing.T) {
253253
require.Len(t, dataframes, 1)
254254
frame := dataframes[0]
255255

256-
require.Equal(t, 11, len(frame.Fields))
256+
require.Equal(t, 12, len(frame.Fields))
257257
// Fields have the correct length
258258
require.Equal(t, 2, frame.Fields[0].Len())
259+
260+
fieldMap := make(map[string]*data.Field)
261+
for _, f := range frame.Fields {
262+
fieldMap[f.Name] = f
263+
}
264+
259265
// First field is timeField
266+
require.Equal(t, "@timestamp", frame.Fields[0].Name)
260267
require.Equal(t, data.FieldTypeNullableTime, frame.Fields[0].Type())
268+
// Second field is logMessageField
269+
require.Equal(t, "line", frame.Fields[1].Name)
261270
require.Equal(t, data.FieldTypeNullableString, frame.Fields[1].Type())
262-
require.Equal(t, "line", frame.Fields[4].Name)
263-
// Correctly uses string types
264-
require.Equal(t, data.FieldTypeNullableString, frame.Fields[1].Type())
271+
// Synthetic id field added for log row uid stability
272+
require.Contains(t, fieldMap, "id")
273+
require.Equal(t, data.FieldTypeNullableString, fieldMap["id"].Type())
265274
// Correctly detects float64 types
266-
require.Equal(t, data.FieldTypeNullableFloat64, frame.Fields[2].Type())
275+
require.Equal(t, data.FieldTypeNullableFloat64, fieldMap["float"].Type())
267276
// Correctly flattens fields
268-
require.Equal(t, "nested.field.double_nested", frame.Fields[7].Name)
269-
require.Equal(t, data.FieldTypeNullableString, frame.Fields[7].Type())
277+
require.Contains(t, fieldMap, "nested.field.double_nested")
278+
require.Equal(t, data.FieldTypeNullableString, fieldMap["nested.field.double_nested"].Type())
270279
// Correctly detects type even if first value is null
271-
require.Equal(t, data.FieldTypeNullableJSON, frame.Fields[9].Type())
280+
require.Equal(t, data.FieldTypeNullableJSON, fieldMap["shapes"].Type())
272281
})
273282
}
274283

0 commit comments

Comments
 (0)