Skip to content

Commit 2ba364f

Browse files
committed
refactor: remove redundant default callbacks and failing test
1 parent 573db46 commit 2ba364f

3 files changed

Lines changed: 2 additions & 30 deletions

File tree

src/embedded/components/IterableEmbeddedBanner/IterableEmbeddedBanner.test.tsx

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -303,19 +303,6 @@ describe('IterableEmbeddedBanner', () => {
303303
}
304304
);
305305
});
306-
307-
it('should call useEmbeddedView with default callbacks when not provided', () => {
308-
render(<IterableEmbeddedBanner message={baseMessage} />);
309-
310-
expect(mockUseEmbeddedView).toHaveBeenCalledWith(
311-
IterableEmbeddedViewType.Banner,
312-
expect.objectContaining({
313-
message: baseMessage,
314-
onButtonClick: expect.any(Function),
315-
onMessageClick: expect.any(Function),
316-
})
317-
);
318-
});
319306
});
320307

321308
describe('Edge cases', () => {

src/embedded/components/IterableEmbeddedBanner/IterableEmbeddedBanner.tsx

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,17 +18,15 @@ import {
1818
IMAGE_WIDTH,
1919
} from './IterableEmbeddedBanner.styles';
2020

21-
const noop = () => {};
22-
2321
/**
2422
* TODO: figure out how default action works.
2523
*/
2624

2725
export const IterableEmbeddedBanner = ({
2826
config,
2927
message,
30-
onButtonClick = noop,
31-
onMessageClick = noop,
28+
onButtonClick,
29+
onMessageClick,
3230
}: IterableEmbeddedComponentProps) => {
3331
const { parsedStyles, media, handleButtonClick, handleMessageClick } =
3432
useEmbeddedView(IterableEmbeddedViewType.Banner, {

src/embedded/components/IterableEmbeddedNotification/IterableEmbeddedNotification.test.tsx

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -278,19 +278,6 @@ describe('IterableEmbeddedNotification', () => {
278278
}
279279
);
280280
});
281-
282-
it('should call useEmbeddedView with default callbacks when not provided', () => {
283-
render(<IterableEmbeddedNotification message={baseMessage} />);
284-
285-
expect(mockUseEmbeddedView).toHaveBeenCalledWith(
286-
IterableEmbeddedViewType.Notification,
287-
expect.objectContaining({
288-
message: baseMessage,
289-
onButtonClick: expect.any(Function),
290-
onMessageClick: expect.any(Function),
291-
})
292-
);
293-
});
294281
});
295282

296283
describe('Edge cases', () => {

0 commit comments

Comments
 (0)