Skip to content

Commit 41f51fe

Browse files
committed
refactor: update setEmail methods in ReactIterableAPI to public and enhance Objective-C bridge for improved accessibility
1 parent 0aafd2a commit 41f51fe

4 files changed

Lines changed: 14 additions & 23 deletions

File tree

ios/RNIterableAPI/RNIterableAPI.mm

Lines changed: 8 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -69,24 +69,15 @@ - (void)initialize2WithApiKey:(NSString *)apiKey
6969
rejecter:reject];
7070
}
7171

72-
// Export the initialize2 method
73-
// RCT_EXPORT_METHOD(initialize2WithApiKey:(NSString *)apiKey
74-
// config:(NSDictionary *)config
75-
// apiEndPointOverride:(NSString *)apiEndPointOverride
76-
// version:(NSString *)version
77-
// resolve:(RCTPromiseResolveBlock)resolve
78-
// reject:(RCTPromiseRejectBlock)reject)
79-
// {
80-
// [_swiftAPI initialize2WithApiKey:apiKey
81-
// config:config
82-
// apiEndPointOverride:apiEndPointOverride
83-
// version:version
84-
// resolver:resolve
85-
// rejecter:reject];
86-
// }
87-
88-
72+
- (void)setEmail:(NSString * _Nullable)email
73+
authToken:(NSString * _Nullable)authToken
74+
{
75+
NSLog(@"ReactNativeSdk setEmail");
76+
[_swiftAPI setEmail:email authToken:authToken];
77+
}
8978

79+
// - (void)setEmail:(NSString * _Nullable)email
80+
// authToken:(NSString * _Nullable)authToken;
9081

9182
@end
9283

ios/RNIterableAPI/ReactIterableAPI.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -118,13 +118,13 @@ open class ReactIterableAPI: RCTEventEmitter {
118118
}
119119

120120
@objc(setEmail:)
121-
func set(email: String?) {
121+
public func setEmail(email: String?) {
122122
ITBInfo()
123123
IterableAPI.email = email
124124
}
125125

126126
@objc(setEmail:authToken:)
127-
func set(email: String?, authToken: String?) {
127+
public func setEmail(email: String?, authToken: String?) {
128128
ITBInfo()
129129
IterableAPI.setEmail(email, authToken)
130130
}

src/api/NativeRNIterableAPI.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,13 +32,13 @@ export interface Spec extends TurboModule {
3232

3333
initialize2WithApiKey(
3434
apiKey: string,
35-
config: IterableConfigDict,
35+
config: { [key: string]: string | number | boolean },
3636
apiEndPointOverride: string,
3737
version: string
3838
): Promise<boolean>;
3939

40-
// // User management
41-
// setEmail(email: string | null, authToken?: string | null): void;
40+
// User management
41+
setEmail(email: string | null, authToken?: string | null): void;
4242
// getEmail(): Promise<string | null>;
4343
// setUserId(userId: string | null, authToken?: string | null): void;
4444
// getUserId(): Promise<string | null>;

src/core/classes/Iterable.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,7 @@ export class Iterable {
186186
static setEmail(email?: string | null, authToken?: string | null) {
187187
Iterable?.logger?.log('setEmail: ' + email);
188188

189-
RNIterableAPI.setEmail(email, authToken);
189+
api.setEmail(email, authToken);
190190
}
191191

192192
/**

0 commit comments

Comments
 (0)