Merge branch 'master' into feature/SDK-121-upgrade-jest

Set CI=true for the circular dependency pre-commit hook so dpdm's ora
spinner does not hang on stdin when lefthook runs the job in parallel.
Without this, the hook deadlocks during merge commits.

Author: jferrao-itrbl

.eslintignore

@@ -26,6 +26,9 @@ jobs:
       - name: Typecheck files
         run: yarn typecheck
 
+      - name: Check circular dependencies
+        run: yarn check:circular
+
   test:
     runs-on: ubuntu-latest
     steps:

.eslintrc.js

@@ -0,0 +1,70 @@
+const reactNativeConfig = require('@react-native/eslint-config/flat');
+const tsEslintPlugin = require('@typescript-eslint/eslint-plugin');
+const reactPlugin = require('eslint-plugin-react');
+const reactNativePlugin = require('eslint-plugin-react-native');
+const tsdoc = require('eslint-plugin-tsdoc');
+
+const typescriptFiles = ['**/*.ts', '**/*.tsx'];
+const [, tsEslintRecommended, tsRecommended] =
+  tsEslintPlugin.configs['flat/recommended'];
+
+module.exports = [
+  {
+    ignores: ['coverage/**/*', 'lib/**/*', 'docs/**/*'],
+  },
+  ...reactNativeConfig,
+  reactPlugin.configs.flat.recommended,
+  {
+    plugins: {
+      'react-native': reactNativePlugin,
+    },
+    rules: reactNativePlugin.configs.all.rules,
+  },
+  {
+    rules: {
+      'react/react-in-jsx-scope': 'off',
+    },
+  },
+  {
+    ...tsEslintRecommended,
+    files: typescriptFiles,
+  },
+  {
+    ...tsRecommended,
+    files: typescriptFiles,
+  },
+  {
+    files: typescriptFiles,
+    plugins: {
+      tsdoc,
+    },
+    languageOptions: {
+      parserOptions: {
+        project: true,
+        tsconfigRootDir: __dirname,
+      },
+    },
+    rules: {
+      '@typescript-eslint/no-var-requires': [
+        'error',
+        { allow: ['/package\\.json$'] },
+      ],
+      '@typescript-eslint/no-require-imports': [
+        'error',
+        { allow: ['/package\\.json$'] },
+      ],
+      'tsdoc/syntax': 'warn',
+    },
+  },
+  {
+    files: [
+      '**/*.test.{js,ts,tsx}',
+      '**/__mocks__/*',
+      '**/__tests__/*',
+    ],
+    rules: {
+      '@typescript-eslint/no-var-requires': 'off',
+      '@typescript-eslint/no-require-imports': 'off',
+    },
+  },
+];

.github/workflows/ci.yml

@@ -7,6 +7,11 @@ pre-commit:
     types:
       glob: "*.{js,ts,jsx,tsx}"
       run: npx tsc
+    circular:
+      glob: "src/**/*.{ts,tsx}"
+      env:
+        CI: "true"
+      run: yarn check:circular
     # version-check:
     #   glob: "package.json"
     #   run: node scripts/checkVersionAndUpdateBuildInfo.js

eslint.config.js

@@ -41,6 +41,7 @@
     "test:coverage": "jest --coverage",
     "typecheck": "tsc",
     "lint": "eslint \"**/*.{js,ts,tsx}\"",
+    "check:circular": "dpdm --no-warning --no-tree -T --circular --exit-code circular:1 src/index.tsx",
     "docs": "typedoc",
     "clean": "del-cli android/build example/android/build example/android/app/build example/ios/build lib",
     "prebuild": "yarn add_build_info",
@@ -86,11 +87,12 @@
     "baseline-browser-mapping": "^2.10.29",
     "commitlint": "^19.6.1",
     "del-cli": "^5.1.0",
-    "eslint": "^8.51.0",
+    "dpdm": "^4.2.0",
+    "eslint": "^9.39.5",
     "eslint-config-prettier": "^10.1.8",
-    "eslint-plugin-jest": "^28.9.0",
+    "eslint-plugin-jest": "^29.0.1",
     "eslint-plugin-prettier": "^5.0.1",
-    "eslint-plugin-tsdoc": "^0.3.0",
+    "eslint-plugin-tsdoc": "^0.5.2",
     "jest": "^29.7.0",
     "prettier": "^3.0.3",
     "prettier-eslint": "^16.4.2",
@@ -112,7 +114,8 @@
   "resolutions": {
     "@types/react": "^19.2.0",
     "babel-jest": "29.7.0",
-    "jest-environment-node": "29.7.0"
+    "jest-environment-node": "29.7.0",
+    "eslint-plugin-ft-flow": "^3.0.11"
   },
   "peerDependencies": {
     "@react-navigation/native": "*",

lefthook.yml

@@ -449,47 +449,30 @@ export class IterableConfig {
       inAppDisplayInterval: this.inAppDisplayInterval,
       /**
        * A boolean indicating if a URL handler is present.
-       *
-       * TODO: Figure out if this is purposeful
        */
-      // eslint-disable-next-line eqeqeq
-      urlHandlerPresent: this.urlHandler != undefined,
+      urlHandlerPresent: this.urlHandler !== undefined,
       /**
        * A boolean indicating if a custom action handler is present.
-       *
-       * TODO: Figure out if this is purposeful
        */
-      // eslint-disable-next-line eqeqeq
-      customActionHandlerPresent: this.customActionHandler != undefined,
+      customActionHandlerPresent: this.customActionHandler !== undefined,
       /**
        * A boolean indicating if an in-app handler is present.
-       *
-       * TODO: Figure out if this is purposeful
        */
-      // eslint-disable-next-line eqeqeq
-      inAppHandlerPresent: this.inAppHandler != undefined,
+      inAppHandlerPresent: this.inAppHandler !== undefined,
       /**
        * A boolean indicating if an authentication handler is present.
-       *
-       * TODO: Figure out if this is purposeful
        */
-      // eslint-disable-next-line eqeqeq
-      authHandlerPresent: this.authHandler != undefined,
+      authHandlerPresent: this.authHandler !== undefined,
       /**
        * A boolean indicating if an embedded message update callback is present.
-       *
-       * TODO: Figure out if this is purposeful
        */
-      // eslint-disable-next-line eqeqeq
-      onEmbeddedMessageUpdatePresent: this.onEmbeddedMessageUpdate != undefined,
+      onEmbeddedMessageUpdatePresent:
+        this.onEmbeddedMessageUpdate !== undefined,
       /**
        * A boolean indicating if an embedded messaging disabled callback is present.
-       *
-       * TODO: Figure out if this is purposeful
        */
-      // eslint-disable-next-line eqeqeq
       onEmbeddedMessagingDisabledPresent:
-        this.onEmbeddedMessagingDisabled != undefined,
+        this.onEmbeddedMessagingDisabled !== undefined,
       /** The log level for the SDK. */
       logLevel: this.logLevel,
       expiringAuthTokenRefreshPeriod: this.expiringAuthTokenRefreshPeriod,