Skip to content

Commit 78927bc

Browse files
committed
refactor: update onMessageClick to accept message parameter and adjust related tests
1 parent c9311c9 commit 78927bc

3 files changed

Lines changed: 5 additions & 5 deletions

File tree

src/embedded/hooks/useEmbeddedView/useEmbeddedView.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ describe('useEmbeddedView', () => {
9797
});
9898

9999
describe('handleButtonClick', () => {
100-
it('calls onButtonClick with the button', () => {
100+
it('calls onButtonClick with the button and message', () => {
101101
const onButtonClick = jest.fn();
102102
const button: IterableEmbeddedMessageElementsButton = {
103103
id: 'btn-1',
@@ -117,7 +117,7 @@ describe('useEmbeddedView', () => {
117117
});
118118

119119
expect(onButtonClick).toHaveBeenCalledTimes(1);
120-
expect(onButtonClick).toHaveBeenCalledWith(button);
120+
expect(onButtonClick).toHaveBeenCalledWith(button, minimalMessage);
121121
});
122122

123123
it('calls Iterable.embeddedManager.handleClick with message, button.id, and button.action', () => {

src/embedded/hooks/useEmbeddedView/useEmbeddedView.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import type { IterableEmbeddedMessageElementsButton } from '../../types/Iterable
66
import { getMedia } from './getMedia';
77
import { getStyles } from './getStyles';
88

9-
const noop = () => {};
9+
const noop = (..._args: unknown[]) => {};
1010

1111
/**
1212
* This hook is used to manage the lifecycle of an embedded view.
@@ -60,7 +60,7 @@ export const useEmbeddedView = (
6060
);
6161

6262
const handleMessageClick = useCallback(() => {
63-
onMessageClick();
63+
onMessageClick(message);
6464
Iterable.embeddedManager.handleClick(
6565
message,
6666
null,

src/embedded/types/IterableEmbeddedComponentProps.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,5 +13,5 @@ export interface IterableEmbeddedComponentProps {
1313
message: IterableEmbeddedMessage
1414
) => void;
1515
/** The function to call when the message is clicked. */
16-
onMessageClick?: () => void;
16+
onMessageClick?: (message: IterableEmbeddedMessage) => void;
1717
}

0 commit comments

Comments
 (0)