Skip to content

Commit 7f043c8

Browse files
committed
refactor: remove getEmbeddedPlacementIds method and related references
1 parent 6dfc081 commit 7f043c8

9 files changed

Lines changed: 1 addition & 87 deletions

File tree

android/src/main/java/com/iterable/reactnative/RNIterableAPIModuleImpl.java

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -719,23 +719,6 @@ public void pauseEmbeddedImpression(String messageId) {
719719
IterableApi.getInstance().getEmbeddedManager().getEmbeddedSessionManager().pauseImpression(messageId);
720720
}
721721

722-
public void getEmbeddedPlacementIds(Promise promise) {
723-
IterableLogger.d(TAG, "getEmbeddedPlacementIds");
724-
try {
725-
List<Long> placementIds = IterableApi.getInstance().getEmbeddedManager().getPlacementIds();
726-
WritableArray writableArray = Arguments.createArray();
727-
if (placementIds != null) {
728-
for (Long placementId : placementIds) {
729-
writableArray.pushDouble(placementId.doubleValue());
730-
}
731-
}
732-
promise.resolve(writableArray);
733-
} catch (Exception e) {
734-
IterableLogger.e(TAG, "Error getting placement IDs: " + e.getLocalizedMessage());
735-
promise.reject("", "Failed to get placement IDs: " + e.getLocalizedMessage());
736-
}
737-
}
738-
739722
public void getEmbeddedMessages(@Nullable ReadableArray placementIds, Promise promise) {
740723
IterableLogger.d(TAG, "getEmbeddedMessages for placements: " + placementIds);
741724

android/src/newarch/java/com/RNIterableAPIModule.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -249,11 +249,6 @@ public void pauseEmbeddedImpression(String messageId) {
249249
moduleImpl.pauseEmbeddedImpression(messageId);
250250
}
251251

252-
@Override
253-
public void getEmbeddedPlacementIds(Promise promise) {
254-
moduleImpl.getEmbeddedPlacementIds(promise);
255-
}
256-
257252
@Override
258253
public void getEmbeddedMessages(@Nullable ReadableArray placementIds, Promise promise) {
259254
moduleImpl.getEmbeddedMessages(placementIds, promise);

android/src/oldarch/java/com/RNIterableAPIModule.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -253,11 +253,6 @@ public void pauseEmbeddedImpression(String messageId) {
253253
moduleImpl.pauseEmbeddedImpression(messageId);
254254
}
255255

256-
@ReactMethod
257-
public void getEmbeddedPlacementIds(Promise promise) {
258-
moduleImpl.getEmbeddedPlacementIds(promise);
259-
}
260-
261256
@ReactMethod
262257
public void getEmbeddedMessages(@Nullable ReadableArray placementIds, Promise promise) {
263258
moduleImpl.getEmbeddedMessages(placementIds, promise);

example/src/components/Embedded/Embedded.tsx

Lines changed: 1 addition & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ import { SafeAreaView } from 'react-native-safe-area-context';
1010
import styles from './Embedded.styles';
1111

1212
export const Embedded = () => {
13-
const [placementIds, setPlacementIds] = useState<number[]>([]);
1413
const [embeddedMessages, setEmbeddedMessages] = useState<
1514
IterableEmbeddedMessage[]
1615
>([]);
@@ -19,14 +18,6 @@ export const Embedded = () => {
1918
Iterable.embeddedManager.syncMessages();
2019
}, []);
2120

22-
const getPlacementIds = useCallback(() => {
23-
return Iterable.embeddedManager.getPlacementIds().then((ids: unknown) => {
24-
console.log(ids);
25-
setPlacementIds(ids as number[]);
26-
return ids;
27-
});
28-
}, []);
29-
3021
const startEmbeddedSession = useCallback(() => {
3122
console.log(
3223
'startEmbeddedSession --> check android/ios logs to check if it worked'
@@ -91,22 +82,16 @@ export const Embedded = () => {
9182
Is embedded manager enabled?{' '}
9283
{Iterable.embeddedManager.isEnabled ? 'Yes' : 'No'}
9384
</Text>
94-
<Text style={styles.text}>
95-
Placement ids: [{placementIds.join(', ')}]
96-
</Text>
9785
<TouchableOpacity style={styles.button} onPress={syncEmbeddedMessages}>
9886
<Text style={styles.buttonText}>Sync messages</Text>
9987
</TouchableOpacity>
100-
<TouchableOpacity style={styles.button} onPress={getPlacementIds}>
101-
<Text style={styles.buttonText}>Get placement ids</Text>
102-
</TouchableOpacity>
10388
<TouchableOpacity style={styles.button} onPress={startEmbeddedSession}>
10489
<Text style={styles.buttonText}>Start session</Text>
10590
</TouchableOpacity>
10691
<TouchableOpacity style={styles.button} onPress={endEmbeddedSession}>
10792
<Text style={styles.buttonText}>End session</Text>
10893
</TouchableOpacity>
109-
<TouchableOpacity style={styles.button} onPress={() => getEmbeddedMessages(placementIds)}>
94+
<TouchableOpacity style={styles.button} onPress={() => getEmbeddedMessages()}>
11095
<Text style={styles.buttonText}>Get messages</Text>
11196
</TouchableOpacity>
11297
</View>

src/__mocks__/MockRNIterableAPI.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -145,10 +145,6 @@ export class MockRNIterableAPI {
145145

146146
static endEmbeddedSession = jest.fn();
147147

148-
static getEmbeddedPlacementIds = jest
149-
.fn()
150-
.mockResolvedValue([1, 2, 3] as number[]);
151-
152148
static syncEmbeddedMessages = jest.fn().mockResolvedValue(undefined);
153149

154150
static getEmbeddedMessages = jest.fn().mockResolvedValue([

src/api/NativeRNIterableAPI.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,6 @@ export interface Spec extends TurboModule {
151151
endEmbeddedSession(): void;
152152
startEmbeddedImpression(messageId: string, placementId: number): void;
153153
pauseEmbeddedImpression(messageId: string): void;
154-
getEmbeddedPlacementIds(): Promise<number[]>;
155154
getEmbeddedMessages(
156155
placementIds: number[] | null
157156
): Promise<EmbeddedMessage[]>;

src/core/classes/IterableApi.ts

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -551,14 +551,6 @@ export class IterableApi {
551551
return RNIterableAPI.pauseEmbeddedImpression(messageId);
552552
}
553553

554-
/**
555-
* Get the embedded placement IDs.
556-
*/
557-
static getEmbeddedPlacementIds() {
558-
IterableLogger.log('getEmbeddedPlacementIds');
559-
return RNIterableAPI.getEmbeddedPlacementIds();
560-
}
561-
562554
/**
563555
* Get the embedded messages.
564556
*

src/embedded/classes/IterableEmbeddedManager.test.ts

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -109,21 +109,6 @@ describe('IterableEmbeddedManager', () => {
109109
});
110110
});
111111

112-
describe('getPlacementIds', () => {
113-
it('should call IterableApi.getEmbeddedPlacementIds', async () => {
114-
// WHEN getPlacementIds is called
115-
const result = await embeddedManager.getPlacementIds();
116-
117-
// THEN IterableApi.getEmbeddedPlacementIds is called
118-
expect(MockRNIterableAPI.getEmbeddedPlacementIds).toHaveBeenCalledTimes(
119-
1
120-
);
121-
122-
// AND the result is returned
123-
expect(result).toEqual([1, 2, 3]);
124-
});
125-
});
126-
127112
describe('getMessages', () => {
128113
it('should call IterableApi.getEmbeddedMessages with placement IDs', async () => {
129114
// GIVEN placement IDs

src/embedded/classes/IterableEmbeddedManager.ts

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -80,22 +80,6 @@ export class IterableEmbeddedManager {
8080
return IterableApi.syncEmbeddedMessages();
8181
}
8282

83-
/**
84-
* Retrieves a list of placement IDs for the embedded manager.
85-
*
86-
* [Placement Documentation](https://support.iterable.com/hc/en-us/articles/23060529977364-Embedded-Messaging-Overview#placements-and-prioritization)
87-
*
88-
* @example
89-
* ```typescript
90-
* Iterable.embeddedManager.getPlacementIds().then(placementIds => {
91-
* console.log('Placement IDs:', placementIds);
92-
* });
93-
* ```
94-
*/
95-
getPlacementIds() {
96-
return IterableApi.getEmbeddedPlacementIds();
97-
}
98-
9983
/**
10084
* Retrieves a list of embedded messages the user is eligible to see.
10185
*

0 commit comments

Comments
 (0)