Skip to content

Commit 8da7a6c

Browse files
committed
Merge branch 'MOB-12194-add-tests-for-iterableinboxemptystate' into MOB-12157-add-test-coverage-to-iterbleinbox-tsx
2 parents 0d8f6c8 + 428a080 commit 8da7a6c

3 files changed

Lines changed: 45 additions & 19 deletions

File tree

src/inbox/components/IterableInboxMessageCell.tsx

Lines changed: 39 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -20,18 +20,16 @@ import type {
2020
import { ITERABLE_INBOX_COLORS } from '../constants';
2121

2222
export const inboxMessageCellTestIDs = {
23-
container: 'inbox-message-cell',
24-
unreadIndicator: 'inbox-message-cell-unread-indicator',
25-
thumbnail: 'inbox-message-cell-thumbnail',
26-
textContainer: 'inbox-message-cell-text-container',
27-
title: 'inbox-message-cell-title',
2823
body: 'inbox-message-cell-body',
24+
container: 'inbox-message-cell',
2925
createdAt: 'inbox-message-cell-created-at',
30-
deleteSlider: 'inbox-message-cell-delete-slider',
31-
selectButton: 'inbox-message-cell-select-button',
32-
cellContainer: 'inbox-message-cell-container',
3326
defaultContainer: 'inbox-message-cell-default-container',
27+
deleteSlider: 'inbox-message-cell-delete-slider',
3428
select: 'inbox-message-cell-select',
29+
textContainer: 'inbox-message-cell-text-container',
30+
thumbnail: 'inbox-message-cell-thumbnail',
31+
title: 'inbox-message-cell-title',
32+
unreadIndicator: 'inbox-message-cell-unread-indicator',
3533
} as const;
3634

3735
/**
@@ -154,9 +152,17 @@ function defaultMessageListLayout(
154152
}
155153

156154
return (
157-
<View testID={inboxMessageCellTestIDs.defaultContainer} style={messageRowStyle(rowViewModel) as ViewStyle}>
155+
<View
156+
testID={inboxMessageCellTestIDs.defaultContainer}
157+
style={messageRowStyle(rowViewModel) as ViewStyle}
158+
>
158159
<View style={unreadIndicatorContainer as ViewStyle}>
159-
{rowViewModel.read ? null : <View testID={inboxMessageCellTestIDs.unreadIndicator} style={unreadIndicator} />}
160+
{rowViewModel.read ? null : (
161+
<View
162+
testID={inboxMessageCellTestIDs.unreadIndicator}
163+
style={unreadIndicator}
164+
/>
165+
)}
160166
</View>
161167
<View
162168
style={
@@ -175,14 +181,29 @@ function defaultMessageListLayout(
175181
/>
176182
) : null}
177183
</View>
178-
<View testID={inboxMessageCellTestIDs.textContainer} style={messageContainer as ViewStyle}>
179-
<Text testID={inboxMessageCellTestIDs.title} numberOfLines={1} ellipsizeMode="tail" style={title}>
184+
<View
185+
testID={inboxMessageCellTestIDs.textContainer}
186+
style={messageContainer as ViewStyle}
187+
>
188+
<Text
189+
testID={inboxMessageCellTestIDs.title}
190+
numberOfLines={1}
191+
ellipsizeMode="tail"
192+
style={title}
193+
>
180194
{messageTitle}
181195
</Text>
182-
<Text testID={inboxMessageCellTestIDs.body} numberOfLines={3} ellipsizeMode="tail" style={body as TextStyle}>
196+
<Text
197+
testID={inboxMessageCellTestIDs.body}
198+
numberOfLines={3}
199+
ellipsizeMode="tail"
200+
style={body as TextStyle}
201+
>
183202
{messageBody}
184203
</Text>
185-
<Text testID={inboxMessageCellTestIDs.createdAt} style={createdAt}>{messageCreatedAt}</Text>
204+
<Text testID={inboxMessageCellTestIDs.createdAt} style={createdAt}>
205+
{messageCreatedAt}
206+
</Text>
186207
</View>
187208
</View>
188209
);
@@ -416,7 +437,10 @@ export const IterableInboxMessageCell = ({
416437

417438
return (
418439
<>
419-
<View testID={inboxMessageCellTestIDs.deleteSlider} style={styles.deleteSlider}>
440+
<View
441+
testID={inboxMessageCellTestIDs.deleteSlider}
442+
style={styles.deleteSlider}
443+
>
420444
<Text style={styles.textStyle}>DELETE</Text>
421445
</View>
422446
<Animated.View

src/inbox/components/IterableInboxMessageDisplay.test.tsx

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -208,11 +208,13 @@ describe('IterableInboxMessageDisplay', () => {
208208
expect(getByText('Inbox')).toBeTruthy();
209209
});
210210

211-
it('should render the return button icon', () => {
211+
it('should render the return button', () => {
212212
const { getByTestId } = render(
213213
<IterableInboxMessageDisplay {...defaultProps} />
214214
);
215-
expect(getByTestId(iterableMessageDisplayTestIds.icon)).toBeTruthy();
215+
expect(
216+
getByTestId(iterableMessageDisplayTestIds.returnButton)
217+
).toBeTruthy();
216218
});
217219

218220
it('should handle missing message title gracefully', () => {

src/inbox/components/IterableInboxMessageDisplay.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@ export const iterableMessageDisplayTestIds = {
3131
returnButton: 'iterable-message-display-return-button',
3232
messageTitle: 'iterable-message-display-message-title',
3333
webview: 'iterable-message-display-webview',
34-
icon: 'iterable-message-display-icon',
3534
};
3635

3736
/**
@@ -218,7 +217,7 @@ export const IterableInboxMessageDisplay = ({
218217
<View style={styles.header}>
219218
<View style={styles.returnButtonContainer}>
220219
<HeaderBackButton
221-
testID={iterableMessageDisplayTestIds.icon}
220+
testID={iterableMessageDisplayTestIds.returnButton}
222221
label="Inbox"
223222
onPress={() => {
224223
returnToInbox();
@@ -236,6 +235,7 @@ export const IterableInboxMessageDisplay = ({
236235
numberOfLines={1}
237236
ellipsizeMode="tail"
238237
style={styles.messageTitleText}
238+
testID={iterableMessageDisplayTestIds.messageTitle}
239239
>
240240
{messageTitle}
241241
</Text>

0 commit comments

Comments
 (0)