feat: update getEmbeddedMessages method to accept multiple placement IDs

Author: lposen

android/src/main/java/com/iterable/reactnative/RNIterableAPIModuleImpl.java

@@ -46,6 +46,7 @@
 import java.util.Map;
 import java.util.HashMap;
 import java.util.List;
+import java.util.ArrayList;
 import java.util.concurrent.CountDownLatch;
 import java.util.concurrent.TimeUnit;
 
@@ -646,12 +647,33 @@ public void onInboxUpdated() {
     // region Embedded messaging
 
 
-    public void getEmbeddedMessages(Integer placementId, Promise promise) {
-        IterableLogger.d(TAG, "getEmbeddedMessages for placement: " + placementId);
+    public void getEmbeddedMessages(@Nullable ReadableArray placementIds, Promise promise) {
+        IterableLogger.d(TAG, "getEmbeddedMessages for placements: " + placementIds);
 
         try {
-            JSONArray embeddedMessageJsonArray = Serialization.serializeEmbeddedMessages(IterableApi.getInstance().getEmbeddedManager().getMessages(placementId));
-            IterableLogger.d(TAG, "Messages for placement: " + embeddedMessageJsonArray);
+            List<IterableEmbeddedMessage> allMessages = new ArrayList<>();
+
+            if (placementIds == null || placementIds.size() == 0) {
+                // If no placement IDs provided, we need to get messages for all possible placements
+                // Since the Android SDK requires a placement ID, we'll use 0 as a default
+                // This might need to be adjusted based on the actual SDK behavior
+                List<IterableEmbeddedMessage> messages = IterableApi.getInstance().getEmbeddedManager().getMessages(0L);
+                if (messages != null) {
+                    allMessages.addAll(messages);
+                }
+            } else {
+                // Convert ReadableArray to individual placement IDs and get messages for each
+                for (int i = 0; i < placementIds.size(); i++) {
+                    long placementId = placementIds.getInt(i);
+                    List<IterableEmbeddedMessage> messages = IterableApi.getInstance().getEmbeddedManager().getMessages(placementId);
+                    if (messages != null) {
+                        allMessages.addAll(messages);
+                    }
+                }
+            }
+
+            JSONArray embeddedMessageJsonArray = Serialization.serializeEmbeddedMessages(allMessages);
+            IterableLogger.d(TAG, "Messages for placements: " + embeddedMessageJsonArray);
 
             promise.resolve(Serialization.convertJsonToArray(embeddedMessageJsonArray));
         } catch (JSONException e) {

android/src/newarch/java/com/RNIterableAPIModule.java

@@ -233,7 +233,7 @@ public void onInboxUpdated() {
   }
 
   @Override
-  public void getEmbeddedMessages(Integer placementId, Promise promise) {
-    moduleImpl.getEmbeddedMessages(placementId, promise);
+  public void getEmbeddedMessages(@Nullable ReadableArray placementIds, Promise promise) {
+    moduleImpl.getEmbeddedMessages(placementIds, promise);
   }
 }

android/src/oldarch/java/com/RNIterableAPIModule.java

@@ -229,8 +229,8 @@ public void pauseAuthRetries(boolean pauseRetry) {
     }
 
     @ReactMethod
-    public void getEmbeddedMessages(Integer placementId, Promise promise) {
-      moduleImpl.getEmbeddedMessages(placementId, promise);
+    public void getEmbeddedMessages(@Nullable ReadableArray placementIds, Promise promise) {
+      moduleImpl.getEmbeddedMessages(placementIds, promise);
     }
 
     public void sendEvent(@NonNull String eventName, @Nullable Object eventData) {

example/src/components/User/User.tsx

@@ -1,5 +1,5 @@
 import { Iterable } from '@iterable/react-native-sdk';
-import { useEffect, useState } from 'react';
+import { useCallback, useEffect, useState } from 'react';
 import { Text, TouchableOpacity, View } from 'react-native';
 
 import { useIterableApp } from '../../hooks';
@@ -17,13 +17,22 @@ export const User = () => {
     }
   }, [isLoggedIn]);
 
+  const getEmbeddedMessages = useCallback(() => {
+    Iterable.getEmbeddedMessages().then((messages: unknown) => {
+      console.log(messages);
+    });
+  }, []);
+
   return (
     <View style={styles.container}>
       <Text style={styles.appName}>Welcome Iterator</Text>
       <Text style={styles.text}>Logged in as {loggedInAs}</Text>
       <TouchableOpacity style={styles.button} onPress={logout}>
         <Text style={styles.buttonText}>Logout</Text>
       </TouchableOpacity>
+      <TouchableOpacity style={styles.button} onPress={getEmbeddedMessages}>
+        <Text style={styles.buttonText}>Get embedded messages</Text>
+      </TouchableOpacity>
     </View>
   );
 };

src/core/classes/Iterable.ts

@@ -918,6 +918,10 @@ export class Iterable {
     );
   }
 
+  static getEmbeddedMessages(placementIds?: number[] | null) {
+    return IterableApi.getEmbeddedMessages(placementIds ?? null);
+  }
+
   /**
    * Sets up event handlers for various Iterable events.
    *