Skip to content

[MOB-1326] add trackEvent #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roninopf merged 4 commits into from
Apr 7, 2020
Merged

[MOB-1326] add trackEvent #1

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
23d162c
add trackEvent
roninopf Apr 6, 2020
9b46520
add trackEvent to index
roninopf Apr 6, 2020
3d5a82a
fix trackEvent call
roninopf Apr 7, 2020
447ba16
Merge branch 'master' into MOB-1326-track-event
roninopf Apr 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Iterable.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,6 +255,11 @@ class Iterable {
console.log("getInAppMessages");
return RNIterableAPI.getInAppMessages().then((messages: Array<any>) => messages.map (message => {return IterableInAppMessage.fromDict(message)}))
}

static track(event: String, dataFields: any | null) {
Comment thread
roninopf marked this conversation as resolved.
Outdated
console.log("track")
Comment thread
roninopf marked this conversation as resolved.
Outdated
return RNIterableAPI.track(event, dataFields)
Comment thread
roninopf marked this conversation as resolved.
Outdated
}
}

export { Iterable, IterableConfig, PushServicePlatform, IterableAction, IterableActionContext, IterableAttributionInfo, IterableCommerceItem };
1 change: 1 addition & 0 deletions index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ export class Iterable {
static trackPushOpenWithCampaignId(campaignId: number, templateId: number, messageId: String | null, appAlreadyRunning: Boolean, dataFields: any | null): void
static trackPurchase(total: number, items: Array<IterableCommerceItem>, dataFields: any | null): void
static trackInAppOpen(message: IterableInAppMessage, location: IterableInAppLocation): void
static track(event: String, dataFields: any | null): void
Comment thread
roninopf marked this conversation as resolved.
Outdated
}

export enum PushServicePlatform {
Expand Down
3 changes: 2 additions & 1 deletion ios/RNIterableAPI/RNIterableAPI.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ @interface RCT_EXTERN_REMAP_MODULE(RNIterableAPI, ReactIterableAPI, NSObject)
RCT_EXTERN_METHOD(getInAppMessages: (RCTPromiseResolveBlock) resolve
rejecter: (RCTPromiseRejectBlock) reject)

RCT_EXTERN_METHOD(track: (NSString *) event)
RCT_EXTERN_METHOD(track: (NSString *) event
Comment thread
roninopf marked this conversation as resolved.
Outdated
dataFields: (NSDictionary *) dataFields)

@end
6 changes: 3 additions & 3 deletions ios/RNIterableAPI/ReactIterableAPI.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,10 +185,10 @@ class ReactIterableAPI: RCTEventEmitter {
resolver(IterableAPI.inAppManager.getMessages().map{ $0.toDict() })
}

@objc(trackEvent:)
func track(event: String) {
@objc(trackEvent:dataFields:)
func track(event: String, dataFields: [AnyHashable: Any]?) {
Comment thread
roninopf marked this conversation as resolved.
Outdated
ITBInfo()
IterableAPI.track(event: event)
IterableAPI.track(event: event, dataFields)
}

private var shouldEmit = false
Expand Down