Skip to content

[MOB-7936] creates IterableEmbeddedMessage class#657

Merged
evantk91 merged 3 commits into
evan/embedded-message-classfrom
evan/MOB-7936-iterable-embedded-message-class
Jun 25, 2025
Merged

[MOB-7936] creates IterableEmbeddedMessage class#657
evantk91 merged 3 commits into
evan/embedded-message-classfrom
evan/MOB-7936-iterable-embedded-message-class

Conversation

@evantk91

@evantk91 evantk91 commented Jun 9, 2025

Copy link
Copy Markdown
Contributor

🔹 JIRA Ticket(s) if any

✏️ Description

This pull request creates the IterableEmbeddedMessage class.

@github-actions

github-actions Bot commented Jun 9, 2025

Copy link
Copy Markdown
Lines Statements Branches Functions
Coverage: 45%
44.69% (236/528) 20.7% (41/198) 38.37% (66/172)

@evantk91 evantk91 changed the title [MOB-7936] adds message class and unit tests [MOB-7936] creates IterableEmbeddedMessage class Jun 9, 2025
@qlty-cloud-legacy

qlty-cloud-legacy Bot commented Jun 9, 2025

Copy link
Copy Markdown

❌ 2 blocking issues (2 total)

Tool Category Rule Count
eslint Lint Error loading TSDoc config file:
Error encountered for /home/runner/work/react-native-sdk/tsdoc.json:
Unable to resolve "extends" reference to "typedoc/tsdoc.json": Cannot find module 'typedoc/tsdoc.json' from '/home/runner/work/react-native-sdk'
2

This is from Qlty Cloud, the successor to Code Climate Quality. Learn more.

@@ -0,0 +1,163 @@
import { IterableEmbeddedMessage } from '../embedded/classes/IterableEmbeddedMessage';

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error loading TSDoc config file:
Error encountered for /home/runner/work/react-native-sdk/tsdoc.json:
Unable to resolve "extends" reference to "typedoc/tsdoc.json": Cannot find module 'typedoc/tsdoc.json' from '/home/runner/work/react-native-sdk'
[eslint:tsdoc/syntax]

@@ -0,0 +1,58 @@
import { IterableEmbeddedMessageMetadata } from './IterableEmbeddedMessageMetadata';

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error loading TSDoc config file:
Error encountered for /home/runner/work/react-native-sdk/tsdoc.json:
Unable to resolve "extends" reference to "typedoc/tsdoc.json": Cannot find module 'typedoc/tsdoc.json' from '/home/runner/work/react-native-sdk'
[eslint:tsdoc/syntax]

Comment thread src/embedded/classes/IterableEmbeddedMessage.ts
Comment thread src/embedded/classes/IterableEmbeddedMessage.ts

@lposen lposen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments

Base automatically changed from evan/MOB-11551-iterable-embedded-message-elements-class to evan/embedded-message-class June 24, 2025 21:04
@@ -0,0 +1,163 @@
import { IterableEmbeddedMessage } from '../embedded/classes/IterableEmbeddedMessage';

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error loading TSDoc config file:
Error encountered for /home/runner/work/react-native-sdk/tsdoc.json:
Unable to resolve "extends" reference to "typedoc/tsdoc.json": Cannot find module 'typedoc/tsdoc.json' from '/home/runner/work/react-native-sdk'
[eslint:tsdoc/syntax]

@@ -0,0 +1,58 @@
import { IterableEmbeddedMessageMetadata } from './IterableEmbeddedMessageMetadata';

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error loading TSDoc config file:
Error encountered for /home/runner/work/react-native-sdk/tsdoc.json:
Unable to resolve "extends" reference to "typedoc/tsdoc.json": Cannot find module 'typedoc/tsdoc.json' from '/home/runner/work/react-native-sdk'
[eslint:tsdoc/syntax]

@@ -0,0 +1,163 @@
import { IterableEmbeddedMessage } from '../embedded/classes/IterableEmbeddedMessage';

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error loading TSDoc config file:
Error encountered for /home/runner/work/react-native-sdk/tsdoc.json:
Unable to resolve "extends" reference to "typedoc/tsdoc.json": Cannot find module 'typedoc/tsdoc.json' from '/home/runner/work/react-native-sdk'
[eslint:tsdoc/syntax]

@@ -0,0 +1,58 @@
import { IterableEmbeddedMessageMetadata } from './IterableEmbeddedMessageMetadata';

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error loading TSDoc config file:
Error encountered for /home/runner/work/react-native-sdk/tsdoc.json:
Unable to resolve "extends" reference to "typedoc/tsdoc.json": Cannot find module 'typedoc/tsdoc.json' from '/home/runner/work/react-native-sdk'
[eslint:tsdoc/syntax]

@@ -0,0 +1,163 @@
import { IterableEmbeddedMessage } from '../embedded/classes/IterableEmbeddedMessage';

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error loading TSDoc config file:
Error encountered for /home/runner/work/react-native-sdk/tsdoc.json:
Unable to resolve "extends" reference to "typedoc/tsdoc.json": Cannot find module 'typedoc/tsdoc.json' from '/home/runner/work/react-native-sdk'
[eslint:tsdoc/syntax]

@@ -0,0 +1,61 @@
import { IterableEmbeddedMessageMetadata } from './IterableEmbeddedMessageMetadata';

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error loading TSDoc config file:
Error encountered for /home/runner/work/react-native-sdk/tsdoc.json:
Unable to resolve "extends" reference to "typedoc/tsdoc.json": Cannot find module 'typedoc/tsdoc.json' from '/home/runner/work/react-native-sdk'
[eslint:tsdoc/syntax]

@evantk91 evantk91 merged commit 8df97eb into evan/embedded-message-class Jun 25, 2025
4 of 5 checks passed
@evantk91 evantk91 deleted the evan/MOB-7936-iterable-embedded-message-class branch June 25, 2025 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants