-
Notifications
You must be signed in to change notification settings - Fork 43
[MOB-11955] configure-new-architecture #694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 4 commits
d00e31d
0b1ed47
b33941c
6acab23
f45c778
0bb7151
7336f84
9a75762
ac23ec2
fa2b756
53b12c3
61ec865
b042322
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| RNIterable_kotlinVersion=1.7.0 | ||
| RNIterable_minSdkVersion=21 | ||
| RNIterable_targetSdkVersion=31 | ||
| RNIterable_compileSdkVersion=31 | ||
| RNIterable_ndkversion=21.4.7075529 | ||
| RNIterable_kotlinVersion=2.0.21 | ||
| RNIterable_minSdkVersion=24 | ||
| RNIterable_targetSdkVersion=35 | ||
| RNIterable_compileSdkVersion=35 | ||
| RNIterable_ndkversion=27.1.12297006 | ||
| android.useAndroidX=true | ||
| android.enableJetifier=true | ||
| android.enableJetifier=true |
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,236 @@ | ||||||
| package com.iterable.reactnative; | ||||||
|
||||||
| package com.iterable.reactnative; | |
| package com.reactnative; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot
AI
Aug 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The sampleMethod appears to be leftover test/example code and should be removed from production code as it doesn't match the other API methods.
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this line doing? Getting the project name from new arch vs. old arch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No -- it's either getting the value of a parameter in the users app or, if it doesn't exist, getting the value in our sdk