Skip to content

[MOB-11957] ios-crashes-when-clicking-track-push-open-with-ca #695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lposen merged 16 commits into from
Sep 11, 2025
Merged

[MOB-11957] ios-crashes-when-clicking-track-push-open-with-ca #695

Show file tree
Hide file tree
Changes from 14 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
32c7eb8
refactor: update ios interfaces to enforce non-nullable parameters fo…
lposen Aug 22, 2025
5d8c543
refactor: update parameter types in RNIterableAPI to use Double to ma…
lposen Aug 22, 2025
b6e4488
refactor: update parameter types in RNIterableAPI to reflect automati…
lposen Aug 27, 2025
3e252ee
Update ios/RNIterableAPI/ReactIterableAPI.swift
lposen Aug 27, 2025
e0d026e
refactor: simplify attribution info handling and improve error report…
lposen Aug 27, 2025
dfb4934
refactor: update templateId parameter type to Double in RNIterableAPI…
lposen Aug 27, 2025
5a946b2
refactor: remove redundant error handling in RNIterableAPI to streaml…
lposen Aug 27, 2025
c009a1e
refactor: update templateId type to double in trackPushOpenWithCampai…
lposen Aug 28, 2025
f9aa273
refactor: update templateId parameter type to nullable in trackPushOp…
lposen Aug 28, 2025
560a8c5
refactor: update parameter types to nullable in RNIterableAPI for con…
lposen Aug 28, 2025
91062db
Merge branch 'new-arch/master' into new-arch/MOB-11957-ios-crashes-wh…
lposen Aug 28, 2025
5b7870a
Merge branch 'new-arch/MOB-11955-configure-new-architecture' into new…
lposen Aug 28, 2025
4cc665f
refactor: add wakeApp placeholder method
lposen Aug 28, 2025
7664ace
Merge branch 'new-arch/master' into new-arch/MOB-11957-ios-crashes-wh…
lposen Sep 5, 2025
18bd0af
refactor: update initialize2WithApiKey so that parameters are always …
lposen Sep 5, 2025
26fa44b
fix: update clickedUrl parameter type to allow null values in trackIn…
lposen Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions android/src/main/java/com/iterable/reactnative/RNIterableAPIModuleImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ public void getUserId(Promise promise) {
promise.resolve(RNIterableInternal.getUserId());
}

public void trackEvent(String name, ReadableMap dataFields) {
public void trackEvent(String name, @Nullable ReadableMap dataFields) {
IterableLogger.v(TAG, "trackEvent");
IterableApi.getInstance().track(name, optSerializedDataFields(dataFields));
}
Expand All @@ -177,16 +177,16 @@ public void updateCart(ReadableArray items) {
IterableApi.getInstance().updateCart(Serialization.commerceItemsFromReadableArray(items));
}

public void trackPurchase(double total, ReadableArray items, ReadableMap dataFields) {
public void trackPurchase(double total, ReadableArray items, @Nullable ReadableMap dataFields) {
IterableLogger.v(TAG, "trackPurchase");
IterableApi.getInstance().trackPurchase(total, Serialization.commerceItemsFromReadableArray(items), optSerializedDataFields(dataFields));
}

public void trackPushOpenWithCampaignId(double campaignId, Double templateId, String messageId, boolean appAlreadyRunning, ReadableMap dataFields) {
public void trackPushOpenWithCampaignId(double campaignId, @Nullable Double templateId, String messageId, boolean appAlreadyRunning, @Nullable ReadableMap dataFields) {

@qlty-cloud-legacy qlty-cloud-legacy Bot Aug 28, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function with many parameters (count = 5): trackPushOpenWithCampaignId [qlty:function-parameters]

@qlty-cloud-legacy qlty-cloud-legacy Bot Aug 28, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function with many parameters (count = 5): trackPushOpenWithCampaignId [qlty:function-parameters]

@qlty-cloud-legacy qlty-cloud-legacy Bot Aug 28, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function with many parameters (count = 5): trackPushOpenWithCampaignId [qlty:function-parameters]

@qlty-cloud-legacy qlty-cloud-legacy Bot Aug 28, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function with many parameters (count = 5): trackPushOpenWithCampaignId [qlty:function-parameters]

@qlty-cloud-legacy qlty-cloud-legacy Bot Aug 28, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function with many parameters (count = 5): trackPushOpenWithCampaignId [qlty:function-parameters]

@qlty-cloud-legacy qlty-cloud-legacy Bot Sep 5, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function with many parameters (count = 5): trackPushOpenWithCampaignId [qlty:function-parameters]

@qlty-cloud-legacy qlty-cloud-legacy Bot Sep 5, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function with many parameters (count = 5): trackPushOpenWithCampaignId [qlty:function-parameters]

@qlty-cloud-legacy qlty-cloud-legacy Bot Sep 5, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function with many parameters (count = 5): trackPushOpenWithCampaignId [qlty:function-parameters]

@qltysh qltysh Bot Sep 11, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function with many parameters (count = 5): trackPushOpenWithCampaignId [qlty:function-parameters]

RNIterableInternal.trackPushOpenWithCampaignId((int) campaignId, templateId != null ? templateId.intValue() : null, messageId, optSerializedDataFields(dataFields));
}

public void updateSubscriptions(ReadableArray emailListIds, ReadableArray unsubscribedChannelIds, ReadableArray unsubscribedMessageTypeIds, ReadableArray subscribedMessageTypeIds, double campaignId, double templateId) {
public void updateSubscriptions(@Nullable ReadableArray emailListIds, @Nullable ReadableArray unsubscribedChannelIds, @Nullable ReadableArray unsubscribedMessageTypeIds, @Nullable ReadableArray subscribedMessageTypeIds, double campaignId, double templateId) {

@qlty-cloud-legacy qlty-cloud-legacy Bot Aug 28, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function with many parameters (count = 6): updateSubscriptions [qlty:function-parameters]

@qlty-cloud-legacy qlty-cloud-legacy Bot Aug 28, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function with many parameters (count = 6): updateSubscriptions [qlty:function-parameters]

@qlty-cloud-legacy qlty-cloud-legacy Bot Aug 28, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function with many parameters (count = 6): updateSubscriptions [qlty:function-parameters]

@qlty-cloud-legacy qlty-cloud-legacy Bot Aug 28, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function with many parameters (count = 6): updateSubscriptions [qlty:function-parameters]

@qlty-cloud-legacy qlty-cloud-legacy Bot Sep 5, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function with many parameters (count = 6): updateSubscriptions [qlty:function-parameters]

@qlty-cloud-legacy qlty-cloud-legacy Bot Sep 5, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function with many parameters (count = 6): updateSubscriptions [qlty:function-parameters]

@qlty-cloud-legacy qlty-cloud-legacy Bot Sep 5, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function with many parameters (count = 6): updateSubscriptions [qlty:function-parameters]

@qltysh qltysh Bot Sep 11, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function with many parameters (count = 6): updateSubscriptions [qlty:function-parameters]

IterableLogger.v(TAG, "updateSubscriptions");
Integer finalCampaignId = null, finalTemplateId = null;
if (campaignId > 0) {
Expand Down Expand Up @@ -265,7 +265,7 @@ public void getAttributionInfo(Promise promise) {
}
}

public void setAttributionInfo(ReadableMap attributionInfoReadableMap) {
public void setAttributionInfo(@Nullable ReadableMap attributionInfoReadableMap) {
IterableLogger.printInfo();
try {
JSONObject attributionInfoJson = Serialization.convertMapToJson(attributionInfoReadableMap);
Expand Down Expand Up @@ -593,7 +593,7 @@ public void removeListeners(double count) {
// Keep: Required for RN built in Event Emitter Calls.
}

public void passAlongAuthToken(String authToken) {
public void passAlongAuthToken(@Nullable String authToken) {
passedAuthToken = authToken;

if (authHandlerCallbackLatch != null) {
Expand Down
15 changes: 6 additions & 9 deletions android/src/newarch/java/com/RNIterableAPIModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ public void getUserId(Promise promise) {
}

@Override
public void trackEvent(String name, ReadableMap dataFields) {
public void trackEvent(String name, @Nullable ReadableMap dataFields) {
moduleImpl.trackEvent(name, dataFields);
}

Expand All @@ -81,17 +81,17 @@ public void updateCart(ReadableArray items) {
}

@Override
public void trackPurchase(double total, ReadableArray items, ReadableMap dataFields) {
public void trackPurchase(double total, ReadableArray items, @Nullable ReadableMap dataFields) {
moduleImpl.trackPurchase(total, items, dataFields);
}

@Override
public void trackPushOpenWithCampaignId(double campaignId, Double templateId, String messageId, boolean appAlreadyRunning, ReadableMap dataFields) {
public void trackPushOpenWithCampaignId(double campaignId, @Nullable Double templateId, String messageId, boolean appAlreadyRunning, @Nullable ReadableMap dataFields) {

@qlty-cloud-legacy qlty-cloud-legacy Bot Sep 5, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function with many parameters (count = 5): trackPushOpenWithCampaignId [qlty:function-parameters]

@qlty-cloud-legacy qlty-cloud-legacy Bot Sep 5, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function with many parameters (count = 5): trackPushOpenWithCampaignId [qlty:function-parameters]

@qltysh qltysh Bot Sep 11, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function with many parameters (count = 5): trackPushOpenWithCampaignId [qlty:function-parameters]

moduleImpl.trackPushOpenWithCampaignId(campaignId, templateId, messageId, appAlreadyRunning, dataFields);
}

@Override
public void updateSubscriptions(ReadableArray emailListIds, ReadableArray unsubscribedChannelIds, ReadableArray unsubscribedMessageTypeIds, ReadableArray subscribedMessageTypeIds, double campaignId, double templateId) {
public void updateSubscriptions(@Nullable ReadableArray emailListIds, @Nullable ReadableArray unsubscribedChannelIds, @Nullable ReadableArray unsubscribedMessageTypeIds, @Nullable ReadableArray subscribedMessageTypeIds, double campaignId, double templateId) {

@qlty-cloud-legacy qlty-cloud-legacy Bot Sep 5, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function with many parameters (count = 6): updateSubscriptions [qlty:function-parameters]

@qlty-cloud-legacy qlty-cloud-legacy Bot Sep 5, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function with many parameters (count = 6): updateSubscriptions [qlty:function-parameters]

@qltysh qltysh Bot Sep 11, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function with many parameters (count = 6): updateSubscriptions [qlty:function-parameters]

moduleImpl.updateSubscriptions(emailListIds, unsubscribedChannelIds, unsubscribedMessageTypeIds, subscribedMessageTypeIds, campaignId, templateId);
}

Expand Down Expand Up @@ -121,7 +121,7 @@ public void getAttributionInfo(Promise promise) {
}

@Override
public void setAttributionInfo(ReadableMap attributionInfoReadableMap) {
public void setAttributionInfo(@Nullable ReadableMap attributionInfoReadableMap) {
moduleImpl.setAttributionInfo(attributionInfoReadableMap);
}

Expand Down Expand Up @@ -185,7 +185,6 @@ public void setAutoDisplayPaused(final boolean paused) {
moduleImpl.setAutoDisplayPaused(paused);
}

@Override
public void wakeApp() {
moduleImpl.wakeApp();
}
Expand All @@ -200,7 +199,6 @@ public void endSession() {
moduleImpl.endSession();
}

@Override
public void updateVisibleRows(ReadableArray visibleRows) {
moduleImpl.updateVisibleRows(visibleRows);
}
Expand All @@ -215,8 +213,7 @@ public void removeListeners(double count) {
moduleImpl.removeListeners(count);
}

@Override
public void passAlongAuthToken(String authToken) {
public void passAlongAuthToken(@Nullable String authToken) {
moduleImpl.passAlongAuthToken(authToken);
}

Expand Down
12 changes: 6 additions & 6 deletions android/src/oldarch/java/com/RNIterableAPIModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ public void getUserId(Promise promise) {
}

@ReactMethod
public void trackEvent(String name, ReadableMap dataFields) {
public void trackEvent(String name, @Nullable ReadableMap dataFields) {
moduleImpl.trackEvent(name, dataFields);
}

Expand All @@ -84,17 +84,17 @@ public void updateCart(ReadableArray items) {
}

@ReactMethod
public void trackPurchase(double total, ReadableArray items, ReadableMap dataFields) {
public void trackPurchase(double total, ReadableArray items, @Nullable ReadableMap dataFields) {
moduleImpl.trackPurchase(total, items, dataFields);
}

@ReactMethod
public void trackPushOpenWithCampaignId(double campaignId, Double templateId, String messageId, boolean appAlreadyRunning, ReadableMap dataFields) {
public void trackPushOpenWithCampaignId(double campaignId, @Nullable Double templateId, String messageId, boolean appAlreadyRunning, @Nullable ReadableMap dataFields) {

@qlty-cloud-legacy qlty-cloud-legacy Bot Sep 5, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function with many parameters (count = 5): trackPushOpenWithCampaignId [qlty:function-parameters]

@qlty-cloud-legacy qlty-cloud-legacy Bot Sep 5, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function with many parameters (count = 5): trackPushOpenWithCampaignId [qlty:function-parameters]

@qltysh qltysh Bot Sep 11, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function with many parameters (count = 5): trackPushOpenWithCampaignId [qlty:function-parameters]

moduleImpl.trackPushOpenWithCampaignId(campaignId, templateId, messageId, appAlreadyRunning, dataFields);
}

@ReactMethod
public void updateSubscriptions(ReadableArray emailListIds, ReadableArray unsubscribedChannelIds, ReadableArray unsubscribedMessageTypeIds, ReadableArray subscribedMessageTypeIds, double campaignId, double templateId) {
public void updateSubscriptions(@Nullable ReadableArray emailListIds, @Nullable ReadableArray unsubscribedChannelIds, @Nullable ReadableArray unsubscribedMessageTypeIds, @Nullable ReadableArray subscribedMessageTypeIds, double campaignId, double templateId) {

@qlty-cloud-legacy qlty-cloud-legacy Bot Sep 5, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function with many parameters (count = 6): updateSubscriptions [qlty:function-parameters]

@qlty-cloud-legacy qlty-cloud-legacy Bot Sep 5, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function with many parameters (count = 6): updateSubscriptions [qlty:function-parameters]

@qltysh qltysh Bot Sep 11, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function with many parameters (count = 6): updateSubscriptions [qlty:function-parameters]

moduleImpl.updateSubscriptions(emailListIds, unsubscribedChannelIds, unsubscribedMessageTypeIds, subscribedMessageTypeIds, campaignId, templateId);
}

Expand Down Expand Up @@ -124,7 +124,7 @@ public void getAttributionInfo(Promise promise) {
}

@ReactMethod
public void setAttributionInfo(ReadableMap attributionInfoReadableMap) {
public void setAttributionInfo(@Nullable ReadableMap attributionInfoReadableMap) {
moduleImpl.setAttributionInfo(attributionInfoReadableMap);
}

Expand Down Expand Up @@ -219,7 +219,7 @@ public void removeListeners(double count) {
}

@ReactMethod
public void passAlongAuthToken(String authToken) {
public void passAlongAuthToken(@Nullable String authToken) {
moduleImpl.passAlongAuthToken(authToken);
}

Expand Down
84 changes: 46 additions & 38 deletions ios/RNIterableAPI/RNIterableAPI.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ - (void)getUserId:(RCTPromiseResolveBlock)resolve
[_swiftAPI getUserId:resolve rejecter:reject];
}

- (void)setInAppShowResponse:(NSNumber *)inAppShowResponse {
- (void)setInAppShowResponse:(double)inAppShowResponse {
Comment thread
evantk91 marked this conversation as resolved.
[_swiftAPI setInAppShowResponse:inAppShowResponse];
}

Expand Down Expand Up @@ -137,8 +137,8 @@ - (void)showMessage:(NSString *)messageId
}

- (void)removeMessage:(NSString *)messageId
location:(NSNumber *)location
source:(NSNumber *)source {
location:(double)location
source:(double)source {
[_swiftAPI removeMessage:messageId location:location source:source];
}

Expand All @@ -154,7 +154,7 @@ - (void)trackEvent:(NSString *)name dataFields:(NSDictionary *)dataFields {
[_swiftAPI trackEvent:name dataFields:dataFields];
}

- (void)trackPushOpenWithCampaignId:(NSNumber *)campaignId
- (void)trackPushOpenWithCampaignId:(double)campaignId
templateId:(NSNumber *)templateId
messageId:(NSString *)messageId
appAlreadyRunning:(BOOL)appAlreadyRunning
Expand All @@ -166,19 +166,19 @@ - (void)trackPushOpenWithCampaignId:(NSNumber *)campaignId
dataFields:dataFields];
}

- (void)trackInAppOpen:(NSString *)messageId location:(NSNumber *)location {
- (void)trackInAppOpen:(NSString *)messageId location:(double)location {
[_swiftAPI trackInAppOpen:messageId location:location];
}

- (void)trackInAppClick:(NSString *)messageId
location:(NSNumber *)location
location:(double)location
clickedUrl:(NSString *)clickedUrl {
[_swiftAPI trackInAppClick:messageId location:location clickedUrl:clickedUrl];
}

- (void)trackInAppClose:(NSString *)messageId
location:(NSNumber *)location
source:(NSNumber *)source
location:(double)location
source:(double)source
clickedUrl:(NSString *)clickedUrl {
[_swiftAPI trackInAppClose:messageId
location:location
Expand All @@ -187,16 +187,16 @@ - (void)trackInAppClose:(NSString *)messageId
}

- (void)inAppConsume:(NSString *)messageId
location:(NSNumber *)location
source:(NSNumber *)source {
location:(double)location
source:(double)source {
[_swiftAPI inAppConsume:messageId location:location source:source];
}

- (void)updateCart:(NSArray *)items {
[_swiftAPI updateCart:items];
}

- (void)trackPurchase:(NSNumber *)total
- (void)trackPurchase:(double)total
items:(NSArray *)items
dataFields:(NSDictionary *)dataFields {
[_swiftAPI trackPurchase:total items:items dataFields:dataFields];
Expand All @@ -216,7 +216,7 @@ - (void)getAttributionInfo:(RCTPromiseResolveBlock)resolve
[_swiftAPI getAttributionInfo:resolve rejecter:reject];
}

- (void)setAttributionInfo:(NSDictionary *)attributionInfo {
- (void)setAttributionInfo:(NSDictionary *_Nullable)attributionInfo {
[_swiftAPI setAttributionInfo:attributionInfo];
}

Expand All @@ -243,12 +243,12 @@ - (void)handleAppLink:(NSString *)appLink
[_swiftAPI handleAppLink:appLink resolver:resolve rejecter:reject];
}

- (void)updateSubscriptions:(NSArray *)emailListIds
unsubscribedChannelIds:(NSArray *)unsubscribedChannelIds
unsubscribedMessageTypeIds:(NSArray *)unsubscribedMessageTypeIds
subscribedMessageTypeIds:(NSArray *)subscribedMessageTypeIds
campaignId:(NSNumber *)campaignId
templateId:(NSNumber *)templateId {
- (void)updateSubscriptions:(NSArray *_Nullable)emailListIds
unsubscribedChannelIds:(NSArray *_Nullable)unsubscribedChannelIds
unsubscribedMessageTypeIds:(NSArray *_Nullable)unsubscribedMessageTypeIds
subscribedMessageTypeIds:(NSArray *_Nullable)subscribedMessageTypeIds
campaignId:(double)campaignId
templateId:(double)templateId {
[_swiftAPI updateSubscriptions:emailListIds
unsubscribedChannelIds:unsubscribedChannelIds
unsubscribedMessageTypeIds:unsubscribedMessageTypeIds
Expand All @@ -269,10 +269,14 @@ - (void)updateVisibleRows:(NSArray *)visibleRows {
[_swiftAPI updateVisibleRows:visibleRows];
}

- (void)passAlongAuthToken:(NSString *)authToken {
- (void)passAlongAuthToken:(NSString *_Nullable)authToken {
[_swiftAPI passAlongAuthToken:authToken];
}

- (void)wakeApp {
// Placeholder function -- this method is only used in Android

@evantk91 evantk91 Sep 5, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice add

}

// MARK: - TurboModule integration
- (std::shared_ptr<facebook::react::TurboModule>)getTurboModule:
(const facebook::react::ObjCTurboModule::InitParams &)params {
Expand Down Expand Up @@ -335,7 +339,7 @@ - (void)passAlongAuthToken:(NSString *)authToken {
[_swiftAPI getUserId:resolve rejecter:reject];
}

RCT_EXPORT_METHOD(setInAppShowResponse : (NSNumber *)inAppShowResponse) {
RCT_EXPORT_METHOD(setInAppShowResponse : (double)inAppShowResponse) {
[_swiftAPI setInAppShowResponse:inAppShowResponse];
}

Expand Down Expand Up @@ -363,8 +367,8 @@ - (void)passAlongAuthToken:(NSString *)authToken {
rejecter:reject];
}

RCT_EXPORT_METHOD(removeMessage : (NSString *)messageId location : (NSNumber *)
location source : (NSNumber *)source) {
RCT_EXPORT_METHOD(removeMessage : (NSString *)messageId location : (double)
location source : (double)source) {
[_swiftAPI removeMessage:messageId location:location source:source];
}

Expand All @@ -382,46 +386,45 @@ - (void)passAlongAuthToken:(NSString *)authToken {
}

RCT_EXPORT_METHOD(
trackPushOpenWithCampaignId : (NSNumber *)
campaignId templateId : (NSNumber *)templateId messageId : (NSString *)
messageId appAlreadyRunning : (BOOL)
appAlreadyRunning dataFields : (NSDictionary *)dataFields) {
trackPushOpenWithCampaignId : (double)campaignId templateId : (NSNumber *)
Comment thread
evantk91 marked this conversation as resolved.
templateId messageId : (NSString *)messageId appAlreadyRunning : (BOOL)
appAlreadyRunning dataFields : (NSDictionary *)dataFields) {
[_swiftAPI trackPushOpenWithCampaignId:campaignId
templateId:templateId
messageId:messageId
appAlreadyRunning:appAlreadyRunning
dataFields:dataFields];
}

RCT_EXPORT_METHOD(trackInAppOpen : (NSString *)messageId location : (NSNumber *)
RCT_EXPORT_METHOD(trackInAppOpen : (NSString *)messageId location : (double)
location) {
[_swiftAPI trackInAppOpen:messageId location:location];
}

RCT_EXPORT_METHOD(trackInAppClick : (NSString *)messageId location : (
NSNumber *)location clickedUrl : (NSString *)clickedUrl) {
RCT_EXPORT_METHOD(trackInAppClick : (NSString *)messageId location : (double)
location clickedUrl : (NSString *)clickedUrl) {
[_swiftAPI trackInAppClick:messageId location:location clickedUrl:clickedUrl];
}

RCT_EXPORT_METHOD(trackInAppClose : (NSString *)messageId location : (
NSNumber *)location source : (NSNumber *)source clickedUrl : (NSString *)
clickedUrl) {
RCT_EXPORT_METHOD(trackInAppClose : (NSString *)messageId location : (double)
location source : (double)source clickedUrl : (NSString *)
clickedUrl) {
Comment thread
evantk91 marked this conversation as resolved.
[_swiftAPI trackInAppClose:messageId
location:location
source:source
clickedUrl:clickedUrl];
}

RCT_EXPORT_METHOD(inAppConsume : (NSString *)messageId location : (NSNumber *)
location source : (NSNumber *)source) {
RCT_EXPORT_METHOD(inAppConsume : (NSString *)messageId location : (double)
location source : (double)source) {
[_swiftAPI inAppConsume:messageId location:location source:source];
}

RCT_EXPORT_METHOD(updateCart : (NSArray *)items) {
[_swiftAPI updateCart:items];
}

RCT_EXPORT_METHOD(trackPurchase : (NSNumber *)total items : (NSArray *)
RCT_EXPORT_METHOD(trackPurchase : (double)total items : (NSArray *)
items dataFields : (NSDictionary *)dataFields) {
[_swiftAPI trackPurchase:total items:items dataFields:dataFields];
}
Expand All @@ -430,6 +433,7 @@ - (void)passAlongAuthToken:(NSString *)authToken {
BOOL)mergeNestedObjects) {
[_swiftAPI updateUser:dataFields mergeNestedObjects:mergeNestedObjects];
}

RCT_EXPORT_METHOD(updateEmail : (NSString *)email authToken : (NSString *)
authToken) {
[_swiftAPI updateEmail:email authToken:authToken];
Expand Down Expand Up @@ -471,8 +475,8 @@ - (void)passAlongAuthToken:(NSString *)authToken {
NSArray *)
unsubscribedChannelIds unsubscribedMessageTypeIds : (NSArray *)
unsubscribedMessageTypeIds subscribedMessageTypeIds : (NSArray *)
subscribedMessageTypeIds campaignId : (NSNumber *)
campaignId templateId : (NSNumber *)templateId) {
subscribedMessageTypeIds campaignId : (double)
campaignId templateId : (double)templateId) {
[_swiftAPI updateSubscriptions:emailListIds
unsubscribedChannelIds:unsubscribedChannelIds
unsubscribedMessageTypeIds:unsubscribedMessageTypeIds
Expand All @@ -491,10 +495,14 @@ - (void)passAlongAuthToken:(NSString *)authToken {
[_swiftAPI updateVisibleRows:visibleRows];
}

RCT_EXPORT_METHOD(passAlongAuthToken : (NSString *)authToken) {
RCT_EXPORT_METHOD(passAlongAuthToken : (NSString *_Nullable)authToken) {
[_swiftAPI passAlongAuthToken:authToken];
}

RCT_EXPORT_METHOD(wakeApp) {
// Placeholder function -- this method is only used in Android
}

#endif

@end
Loading
Loading