Skip to content

fix: xcode 26.4 builds fail#66

Merged
g4rb4g3 merged 1 commit intomasterfrom
bugfix/xcode-26.4-builds-fail
Apr 8, 2026
Merged

fix: xcode 26.4 builds fail#66
g4rb4g3 merged 1 commit intomasterfrom
bugfix/xcode-26.4-builds-fail

Conversation

@g4rb4g3
Copy link
Copy Markdown
Contributor

@g4rb4g3 g4rb4g3 commented Apr 8, 2026

This PR fixes the failing builds with Xcode 26.4 by bumping fmt.
facebook/react-native#56099

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 8, 2026

node_modules/react-native/React/CoreModules/RCTTiming.h:undefined

Removal of RCTFrameUpdateObserver from the interface may break expected frame update notifications (e.g. didUpdateFrame:), potentially causing logic errors.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 8, 2026

node_modules/react-native/React/CoreModules/RCTTiming.mm:undefined

The NSTimer (_timer) scheduled in setup is never invalidated in invalidate, risking that it will continue firing after the object is disposed. Consider adding:

  [_timer invalidate];
  _timer = nil;
  _bridge = nil;

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 8, 2026

node_modules/react-native/React/CoreModules/RCTTiming.mm:undefined

Removal of the call to stopTimers in appDidMoveToBackground may allow timers to continue running while the app is in the background, potentially leading to unnecessary resource usage or battery drain.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 8, 2026

The changes remove timer management functions and observer conformance without replacing their logic, which can lead to unexpected timer behavior and potential resource leaks.

@g4rb4g3 g4rb4g3 merged commit de4db95 into master Apr 8, 2026
2 checks passed
@g4rb4g3 g4rb4g3 deleted the bugfix/xcode-26.4-builds-fail branch April 8, 2026 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant