Add support of discords "new" components v2!#193
Merged
Conversation
ItzDerock
requested changes
Sep 6, 2025
Owner
ItzDerock
left a comment
ItzDerock
left a comment
There was a problem hiding this comment.
overall lgtm, will test it over weekend. Just some small changes needed.
Contributor
Author
|
Alright, feel free to take a look now. All the requested changes should be done as well as some fixes I missed last time |
ItzDerock
requested changes
Sep 8, 2025
Owner
ItzDerock
left a comment
ItzDerock
left a comment
There was a problem hiding this comment.
Just one last change. This PR introduces a lot of components declared using the const ... syntax. Existing components are declared using the function ... syntax. To be consistent, refactor the const over to function. I marked out the first two I saw, but I think there's a few more.
Contributor
Author
|
Alright, that should be all of them. I also changed spelling on a few things. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for the new discord components v2. There isn't much else to say about it.