Skip to content

Commit 2f073f0

Browse files
committed
Update JsonNodeJsonConverter and JsonObjectJsonConverter to allow nullable return types for CreateJsonNode method
1 parent 77b9394 commit 2f073f0

3 files changed

Lines changed: 5 additions & 5 deletions

File tree

ReflectorNet/src/Convertor/Json/JsonArrayJsonConverter.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,9 +44,9 @@ public class JsonArrayJsonConverter : JsonNodeJsonConverter<JsonArray>, IJsonSch
4444
public override JsonNode GetSchema() => Schema;
4545
public override JsonNode GetSchemaRef() => SchemaRef;
4646

47-
protected override JsonArray CreateJsonNode(JsonElement element)
47+
protected override JsonArray? CreateJsonNode(JsonElement element)
4848
{
49-
return JsonArray.Create(element)!;
49+
return JsonArray.Create(element);
5050
}
5151
}
5252
}

ReflectorNet/src/Convertor/Json/JsonNodeJsonConverter.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ namespace com.IvanMurzak.ReflectorNet.Json
1818
public abstract class JsonNodeJsonConverter<T> : JsonSchemaConverter<T>, IJsonSchemaConverter
1919
where T : JsonNode
2020
{
21-
protected abstract T CreateJsonNode(JsonElement element);
21+
protected abstract T? CreateJsonNode(JsonElement element);
2222
public override T? Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options)
2323
{
2424
// Handle null values for nullable types

ReflectorNet/src/Convertor/Json/JsonObjectJsonConverter.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,9 +31,9 @@ public class JsonObjectJsonConverter : JsonNodeJsonConverter<JsonObject>, IJsonS
3131
public override JsonNode GetSchema() => Schema;
3232
public override JsonNode GetSchemaRef() => SchemaRef;
3333

34-
protected override JsonObject CreateJsonNode(JsonElement element)
34+
protected override JsonObject? CreateJsonNode(JsonElement element)
3535
{
36-
return JsonObject.Create(element)!;
36+
return JsonObject.Create(element);
3737
}
3838
}
3939
}

0 commit comments

Comments
 (0)