Refactor MethodWrapper and add ConvertParameterStringToEnum utility#29
Merged
IvanMurzak merged 3 commits intomainfrom Nov 11, 2025
Merged
Refactor MethodWrapper and add ConvertParameterStringToEnum utility#29IvanMurzak merged 3 commits intomainfrom
IvanMurzak merged 3 commits intomainfrom
Conversation
…gic and add ConvertParameterStringToEnum utility
Contributor
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the MethodWrapper class to improve code organization and maintainability by extracting enum conversion logic into a reusable utility method and streamlining method creation.
- Extracted
ConvertStringToEnummethod fromMethodWrapper.Static.csintoStringUtils.ConvertParameterStringToEnumfor better reusability - Removed unnecessary
virtualmodifiers fromMethodWrapperproperties (InputSchema,OutputSchema,Description) - Refactored if-else statements in factory methods to more concise ternary operators
Reviewed Changes
Copilot reviewed 4 out of 61 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ReflectorNet/src/Utils/StringUtils.cs | Added ConvertParameterStringToEnum utility method for converting string parameters to enum types |
| ReflectorNet/src/Reflector/MethodWrapper.cs | Removed virtual modifiers from properties and updated calls to use the new StringUtils.ConvertParameterStringToEnum method |
| ReflectorNet/src/Reflector/MethodWrapper.Static.cs | Removed ConvertStringToEnum method (moved to StringUtils), refactored factory methods to use ternary operators, and removed unused using System; import |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Streamline method creation logic in MethodWrapper and introduce a utility for converting string parameters to enum types.