Update/serialization deserialization

ReflectorNet.Tests/src/ReflectorTests/SerializePopulateTests.cs

@@ -30,13 +30,15 @@ void ActAssertPopulate(object? original, Type? fallbackType = null)
             var targetObject = reflector.CreateInstance(type);
 
             var populateLogger = new StringBuilderLogger();
-            var populateOutput = reflector.TryPopulate(
+            var success = reflector.TryPopulate(
                 obj: ref targetObject,
                 data: serialized,
                 fallbackObjType: type,
                 logs: new Logs(),
                 logger: populateLogger);
 
+            Assert.True(success);
+
             _output.WriteLine($"Population:\n{populateLogger}");
 
             // Assert
@@ -53,6 +55,8 @@ void ActAssertPopulate(object? original, Type? fallbackType = null)
             _output.WriteLine($"Serialized JSON:\n{serialized.ToJson(reflector)}\n");
 
             Assert.Equal(originalJson, populatedJson);
+
+            _output.WriteLine($"============================\n");
         }
 
         [Fact]

ReflectorNet.Tests/src/SchemaTests/SchemaSerializationValidationTests.cs

@@ -103,7 +103,7 @@ private void ValidateBasicSchemaConformance(JsonNode schema, object serialized,
 
             // Convert serialized object to JSON and extract the "value" field
             var json = serialized.ToJson(reflector);
-            var jsonNode = JsonNode.Parse(json);
+            var jsonNode = JsonNode.Parse(json!);
 
             // SerializedMember has structure: { "name": "...", "typeName": "...", "value": ... }
             // We need to extract just the "value" field to compare against the schema

ReflectorNet.Tests/src/SchemaTests/SerializedMemberSchemaTests.cs

@@ -59,7 +59,7 @@ public void SerializedMember_Should_Serialize_PrimitiveTypes_Correctly(object va
             var json = serialized.ToJson(reflector);
 
             // Parse and validate JSON structure
-            var jsonNode = JsonNode.Parse(json);
+            var jsonNode = JsonNode.Parse(json!);
             Assert.NotNull(jsonNode);
 
             var jsonObj = jsonNode!.AsObject();
@@ -85,7 +85,7 @@ public void SerializedMember_Should_Serialize_Null_Correctly()
             var json = serialized.ToJson(reflector);
 
             // Parse and validate JSON structure
-            var jsonNode = JsonNode.Parse(json);
+            var jsonNode = JsonNode.Parse(json!);
             Assert.NotNull(jsonNode);
 
             var jsonObj = jsonNode!.AsObject();
@@ -111,7 +111,7 @@ public void SerializedMember_Should_Serialize_Array_Correctly()
             var json = serialized.ToJson(reflector);
 
             // Parse and validate JSON structure
-            var jsonNode = JsonNode.Parse(json);
+            var jsonNode = JsonNode.Parse(json!);
             Assert.NotNull(jsonNode);
 
             var jsonObj = jsonNode!.AsObject();
@@ -136,7 +136,7 @@ public void SerializedMember_Should_Serialize_Object_Correctly()
             var json = serialized.ToJson(reflector);
 
             // Parse and validate JSON structure
-            var jsonNode = JsonNode.Parse(json);
+            var jsonNode = JsonNode.Parse(json!);
             Assert.NotNull(jsonNode);
 
             var jsonObj = jsonNode!.AsObject();

ReflectorNet/src/Converter/IReflectionConverter.cs

@@ -45,7 +45,7 @@ bool TryPopulate(
             Reflector reflector,
             ref object? obj,
             SerializedMember data,
-            Type? fallbackType = null,
+            Type type,
             int depth = 0,
             Logs? logs = null,
             BindingFlags flags = BindingFlags.Public | BindingFlags.NonPublic | BindingFlags.Instance,

ReflectorNet/src/Converter/Json/BigIntegerJsonConverter.cs

@@ -22,7 +22,7 @@ public class BigIntegerJsonConverter : JsonSchemaConverter<BigInteger>, IJsonSch
         public static JsonNode Schema => new JsonObject
         {
             [JsonSchema.Type] = JsonSchema.String,
-            ["description"] = "A large integer represented as a string"
+            [JsonSchema.Description] = "A large integer represented as a string"
         };
 
         public static JsonNode SchemaRef => new JsonObject

ReflectorNet/src/Converter/Json/VersionJsonConverter.cs

@@ -7,16 +7,28 @@
 
 using System;
 using System.Text.Json;
-using System.Text.Json.Serialization;
+using System.Text.Json.Nodes;
 using com.IvanMurzak.ReflectorNet.Utils;
 
 namespace com.IvanMurzak.ReflectorNet.Json
 {
     /// <summary>
     /// JsonConverter that handles conversion between JSON strings and System.Version.
     /// </summary>
-    public class VersionJsonConverter : JsonConverter<Version>
+    public class VersionJsonConverter : JsonSchemaConverter<Version>, IJsonSchemaConverter
     {
+        public static JsonNode Schema => new JsonObject
+        {
+            [JsonSchema.Type] = JsonSchema.String,
+        };
+        public static JsonNode SchemaRef => new JsonObject
+        {
+            [JsonSchema.Ref] = JsonSchema.RefValue + StaticId
+        };
+
+        public override JsonNode GetSchema() => Schema;
+        public override JsonNode GetSchemaRef() => SchemaRef;
+
         public override Version? Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options)
         {
             if (reader.TokenType == JsonTokenType.Null)

ReflectorNet/src/Converter/Reflection/ArrayReflectionConverter.cs

@@ -87,7 +87,7 @@ protected override SerializedMember InternalSerialize(
 
                     if (logger?.IsEnabled(LogLevel.Trace) == true)
                         logger.LogTrace("{padding} Serializing item '{index}' of type '{type}' in '{objType}'.\nPath: {path}",
-                            StringUtils.GetPadding(depth), index, currentType?.GetTypeId(), obj.GetType().GetTypeId(), context?.GetPath(obj));
+                            StringUtils.GetPadding(depth), index, currentType?.GetTypeId().ValueOrNull(), obj.GetType().GetTypeId().ValueOrNull(), context?.GetPath(obj));
 
                     if (thisElementType != null && reflector.Converters.IsTypeBlacklisted(thisElementType))
                     {
@@ -119,7 +119,7 @@ protected override SerializedMember InternalSerialize(
                 // Handle non-recursive serialization
                 return SerializedMember.FromJson(
                     type: type,
-                    json: obj.ToJson(reflector),
+                    json: obj.ToJson(reflector, depth: depth, logger: logger),
                     name: name);
             }
         }

ReflectorNet/src/Converter/Reflection/Base/BaseReflectionConverter.Populate.cs

@@ -22,57 +22,45 @@ public virtual bool TryPopulate(
             Reflector reflector,
             ref object? obj,
             SerializedMember data,
-            Type? fallbackType = null,
+            Type type,
             int depth = 0,
             Logs? logs = null,
             BindingFlags flags = BindingFlags.Public | BindingFlags.NonPublic | BindingFlags.Instance,
             ILogger? logger = null)
         {
             var padding = StringUtils.GetPadding(depth);
 
-            var objType = TypeUtils.GetTypeWithNamePriority(data, fallbackType, out var typeError) ?? obj?.GetType();
-            if (objType == null)
-            {
-                if (logger?.IsEnabled(LogLevel.Error) == true)
-                    logger.LogError($"{padding}Failed to determine type for object '{data.name.ValueOrNull()}'. {typeError}");
-
-                if (logs != null)
-                    logs.Error($"Failed to determine type for object '{data.name.ValueOrNull()}'. {typeError}", depth);
-
-                return false;
-            }
-
             if (obj == null)
             {
                 // obj = CreateInstance(reflector, objType);
                 obj = reflector.Deserialize(
                     data: data,
-                    fallbackType: objType,
+                    fallbackType: type,
                     depth: depth,
                     logs: logs,
                     logger: logger);
 
                 if (obj == null)
                 {
                     if (logger?.IsEnabled(LogLevel.Error) == true)
-                        logger.LogError($"{padding}Object '{data.name.ValueOrNull()}' population failed: Object is null. Instance creation failed for type '{objType.GetTypeId()}'.");
+                        logger.LogError($"{padding}Object '{data.name.ValueOrNull()}' population failed: Object is null. Instance creation failed for type '{type.GetTypeId()}'.");
 
                     if (logs != null)
-                        logs.Error($"Object '{data.name.ValueOrNull()}' population failed: Object is null. Instance creation failed for type '{objType.GetTypeId()}'.", depth);
+                        logs.Error($"Object '{data.name.ValueOrNull()}' population failed: Object is null. Instance creation failed for type '{type.GetTypeId()}'.", depth);
 
                     return false;
                 }
 
                 if (logger?.IsEnabled(LogLevel.Trace) == true)
-                    logger.LogTrace($"{padding}Object '{data.name.ValueOrNull()}' populated with type '{objType.GetTypeId()}'.");
+                    logger.LogTrace($"{padding}Object '{data.name.ValueOrNull()}' populated with type '{type.GetTypeId()}'.");
 
                 if (logs != null)
-                    logs.Success($"Object '{data.name.ValueOrNull()}' populated with type '{objType.GetTypeId()}'.", depth);
+                    logs.Success($"Object '{data.name.ValueOrNull()}' populated with type '{type.GetTypeId()}'.", depth);
 
                 return true;
             }
 
-            if (!TypeUtils.IsCastable(obj.GetType(), objType))
+            if (!TypeUtils.IsCastable(obj.GetType(), type))
             {
                 if (logger?.IsEnabled(LogLevel.Error) == true)
                     logger.LogError($"{padding}Type mismatch: '{data.typeName}' vs '{obj.GetType().GetTypeId().ValueOrNull()}'.");
@@ -91,7 +79,7 @@ public virtual bool TryPopulate(
                     var success = SetValue(
                         reflector: reflector,
                         obj: ref obj,
-                        type: objType,
+                        type: type,
                         value: data.valueJsonElement,
                         depth: depth,
                         logs: logs,
@@ -136,7 +124,7 @@ public virtual bool TryPopulate(
                     var success = TryPopulateField(
                         reflector,
                         obj: ref obj,
-                        objType: objType,
+                        objType: type,
                         fieldValue: field,
                         depth: nextDepth,
                         logs: logs,
@@ -180,7 +168,7 @@ public virtual bool TryPopulate(
                     var success = TryPopulateProperty(
                         reflector,
                         obj: ref obj,
-                        objType: objType,
+                        objType: type,
                         propertyValue: property,
                         depth: nextDepth,
                         logs: logs,

ReflectorNet/src/Converter/Reflection/Base/BaseReflectionConverter.Serialize.cs

@@ -23,7 +23,7 @@ public abstract partial class BaseReflectionConverter<T> : IReflectionConverter
         public virtual SerializedMember Serialize(
             Reflector reflector,
             object? obj,
-            Type? type = null,
+            Type? fallbackType = null,
             string? name = null,
             bool recursive = true,
             BindingFlags flags = BindingFlags.Public | BindingFlags.NonPublic | BindingFlags.Instance,
@@ -32,10 +32,12 @@ public virtual SerializedMember Serialize(
             ILogger? logger = null,
             SerializationContext? context = null)
         {
+            var actualType = fallbackType ?? obj?.GetType() ?? typeof(T);
+
             return InternalSerialize(
                 reflector: reflector,
                 obj: obj,
-                type: type ?? obj?.GetType() ?? typeof(T),
+                type: actualType,
                 name: name,
                 recursive: recursive,
                 flags: flags,
@@ -63,13 +65,6 @@ public virtual SerializedMember Serialize(
 
             foreach (var field in fields)
             {
-                if (GetIgnoredFields().Contains(field.Name))
-                {
-                    if (logger?.IsEnabled(LogLevel.Trace) == true)
-                        logger.LogTrace("{padding}Skipping serialization of field '{fieldName}' in '{objType}' because it is ignored.\nPath: {path}",
-                            StringUtils.GetPadding(depth + 1), field.Name, objType.GetTypeId(), context?.GetPath(obj));
-                    continue;
-                }
                 if (reflector.Converters.IsTypeBlacklisted(field.FieldType))
                 {
                     if (logger?.IsEnabled(LogLevel.Trace) == true)
@@ -128,24 +123,17 @@ public virtual SerializedMember Serialize(
 
             foreach (var prop in properties)
             {
-                if (GetIgnoredProperties().Contains(prop.Name))
-                {
-                    if (logger?.IsEnabled(LogLevel.Trace) == true)
-                        logger.LogTrace("{padding} Skipping serialization of property '{propertyName}' in '{objType}' because it is ignored.\nPath: {path}",
-                            StringUtils.GetPadding(depth + 1), prop.Name, objType.GetTypeId(), context?.GetPath(obj));
-                    continue;
-                }
                 if (reflector.Converters.IsTypeBlacklisted(prop.PropertyType))
                 {
                     if (logger?.IsEnabled(LogLevel.Trace) == true)
-                        logger.LogTrace("{padding} Skipping serialization of property '{propertyName}' of type '{type}' in '{objType}' because its type is blacklisted.\nPath: {path}",
+                        logger.LogTrace("{padding}Skipping serialization of property '{propertyName}' of type '{type}' in '{objType}' because its type is blacklisted.\nPath: {path}",
                             StringUtils.GetPadding(depth + 1), prop.Name, prop.PropertyType.GetTypeId(), objType.GetTypeId(), context?.GetPath(obj));
                     continue;
                 }
                 try
                 {
                     if (logger?.IsEnabled(LogLevel.Trace) == true)
-                        logger.LogTrace("{padding} Serializing property '{propertyName}' of type '{type}' in '{objType}'.\nPath: {path}",
+                        logger.LogTrace("{padding}Serializing property '{propertyName}' of type '{type}' in '{objType}'.\nPath: {path}",
                             StringUtils.GetPadding(depth + 1), prop.Name, prop.PropertyType.GetTypeId(), objType.GetTypeId(), context?.GetPath(obj));
 
                     var value = prop.GetValue(obj);

ReflectorNet/src/Converter/Reflection/Base/BaseReflectionConverter.cs

@@ -103,7 +103,22 @@ public virtual int SerializationPriority(Type type, ILogger? logger = null)
         /// Default implementation returns public fields that are not marked with [Obsolete] or [NonSerialized].
         /// Derived classes can override to customize field selection.
         /// </summary>
-        public virtual IEnumerable<FieldInfo>? GetSerializableFields(
+        public IEnumerable<FieldInfo>? GetSerializableFields(
+            Reflector reflector,
+            Type objType,
+            BindingFlags flags = BindingFlags.Public | BindingFlags.NonPublic | BindingFlags.Instance,
+            ILogger? logger = null)
+        {
+            return GetSerializableFieldsInternal(reflector, objType, flags, logger)
+                ?.Where(field => !GetIgnoredFields().Contains(field.Name));
+        }
+
+        /// <summary>
+        /// Gets the serializable fields for the specified type.
+        /// Default implementation returns public fields that are not marked with [Obsolete] or [NonSerialized].
+        /// Derived classes can override to customize field selection.
+        /// </summary>
+        protected virtual IEnumerable<FieldInfo>? GetSerializableFieldsInternal(
             Reflector reflector,
             Type objType,
             BindingFlags flags = BindingFlags.Public | BindingFlags.NonPublic | BindingFlags.Instance,
@@ -120,7 +135,22 @@ public virtual int SerializationPriority(Type type, ILogger? logger = null)
         /// Default implementation returns readable properties that are not marked with [Obsolete].
         /// Derived classes can override to customize property selection.
         /// </summary>
-        public virtual IEnumerable<PropertyInfo>? GetSerializableProperties(
+        public IEnumerable<PropertyInfo>? GetSerializableProperties(
+            Reflector reflector,
+            Type objType,
+            BindingFlags flags = BindingFlags.Public | BindingFlags.NonPublic | BindingFlags.Instance,
+            ILogger? logger = null)
+        {
+            return GetSerializablePropertiesInternal(reflector, objType, flags, logger)
+                ?.Where(prop => !GetIgnoredProperties().Contains(prop.Name));
+        }
+
+        /// <summary>
+        /// Gets the serializable properties for the specified type.
+        /// Default implementation returns readable properties that are not marked with [Obsolete].
+        /// Derived classes can override to customize property selection.
+        /// </summary>
+        protected virtual IEnumerable<PropertyInfo>? GetSerializablePropertiesInternal(
             Reflector reflector,
             Type objType,
             BindingFlags flags = BindingFlags.Public | BindingFlags.NonPublic | BindingFlags.Instance,

ReflectorNet/src/Converter/Reflection/GenericReflectionConverter.cs

@@ -60,7 +60,7 @@ protected override SerializedMember InternalSerialize(
                         valueJsonElement = new JsonObject().ToJsonElement()
                     };
                 }
-                return SerializedMember.FromJson(type, obj.ToJson(reflector, logger: logger), name: name);
+                return SerializedMember.FromJson(type, obj.ToJson(reflector, depth: depth, logger: logger), name: name);
             }
             throw new ArgumentException($"Unsupported type: '{type.GetTypeId()}' for converter '{GetType().GetTypeShortName()}'.");
         }

ReflectorNet/src/Converter/Reflection/IgnoreFieldsAndPropertiesReflectionConverter.cs

@@ -33,26 +33,26 @@ public IgnoreFieldsAndPropertiesReflectionConverter(bool ignoreFields, bool igno
         /// </summary>
         public override bool AllowCascadeSerialization => false;
 
-        public override IEnumerable<FieldInfo>? GetSerializableFields(
+        protected override IEnumerable<FieldInfo>? GetSerializableFieldsInternal(
             Reflector reflector,
             Type objType,
             BindingFlags flags,
             ILogger? logger = null)
         {
             return _ignoreFields
                 ? null
-                : base.GetSerializableFields(reflector, objType, flags, logger);
+                : base.GetSerializableFieldsInternal(reflector, objType, flags, logger);
         }
 
-        public override IEnumerable<PropertyInfo>? GetSerializableProperties(
+        protected override IEnumerable<PropertyInfo>? GetSerializablePropertiesInternal(
             Reflector reflector,
             Type objType,
             BindingFlags flags,
             ILogger? logger = null)
         {
             return _ignoreProperties
                 ? null
-                : base.GetSerializableProperties(reflector, objType, flags, logger);
+                : base.GetSerializablePropertiesInternal(reflector, objType, flags, logger);
         }
     }
 }