feat: Add batch blacklist methods for types and string names in Reflector#54
Merged
Merged
Conversation
Contributor
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds batch blacklisting functionality to the Reflector's converter system, allowing multiple types to be blacklisted in a single operation, either by Type objects or by string type names. The implementation includes optimized cache invalidation that only triggers when new types are actually added to the blacklist.
Changes:
- Added batch blacklisting methods (
BlacklistTypes) for bothType[]andstring[]parameters - Added string-based single type blacklisting method (
BlacklistType(string)) - Added comprehensive unit tests covering edge cases like nulls, duplicates, empty arrays, and cache invalidation
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| ReflectorNet/src/Reflector/Reflector.Registry.cs | Implements batch blacklisting methods with optimized cache invalidation logic, adds support for string-based type name blacklisting |
| ReflectorNet.Tests/src/ReflectorTests/IsTypeBlacklistedTests.cs | Adds 16 comprehensive unit tests covering batch operations, string-based blacklisting, null handling, deduplication, and cache invalidation scenarios |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds comprehensive support for batch blacklisting of types, both by
Typeand by string type name, to the Reflector's converter system. It introduces new methods for blacklisting multiple types at once, improves cache invalidation logic, and adds extensive unit tests to ensure correct behavior, including handling of nulls, duplicates, and derived types.Batch Blacklisting Functionality
BlacklistTypes(params Type[] types)to allow blacklisting multiple types at once, with logic to ignore nulls, deduplicate, and only invalidate the cache if new types are added.BlacklistTypes(params string[] typeFullNames)andBlacklistType(string typeFullName)to allow blacklisting by string type names, resolving types usingTypeUtils.GetType, and handling invalid names gracefully.Unit Testing Enhancements
Typeand string names, handling of nulls, empty arrays, duplicates, derived types, generic types, and cache invalidation.Utilities and Imports
com.IvanMurzak.ReflectorNet.Utilsto support type resolution by string name.