Handle JsonException in TryUnstringifyJson calls

[IvanMurzak]

Wrapped calls to JsonUtils.TryUnstringifyJson in try-catch blocks to handle potential JsonException and prevent crashes when input is not a stringified JSON. Also moved the file header comment in JsonUtils.cs outside the namespace for clarity.

[github-actions]

Test Results

    2 files  ±0      2 suites  ±0   8m 27s ⏱️ -9s
1 146 tests ±0  1 146 ✅ ±0  0 💤 ±0  0 ❌ ±0 
2 292 runs  ±0  2 292 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 1523800. ± Comparison against base commit cca4ddd.

[Copilot]

Pull request overview

This pull request addresses potential crashes from JsonException when calling JsonUtils.TryUnstringifyJson by wrapping those calls in try-catch blocks. Additionally, the file header comment in JsonUtils.cs is moved outside the namespace for better organization.

Changes:

• Moved file header comment outside the namespace in JsonUtils.cs
• Added try-catch blocks around TryUnstringifyJson calls in two locations within MethodWrapper.cs to handle JsonException

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
ReflectorNet/src/Utils/Json/JsonUtils.cs	Relocated file header comment outside the namespace declaration
ReflectorNet/src/Reflector/MethodWrapper.cs	Added exception handling around TryUnstringifyJson calls in two parameter processing methods

Comments suppressed due to low confidence (1)

ReflectorNet/src/Utils/Json/JsonUtils.cs:25

• The TryUnstringifyJson method violates the Try* pattern convention. Methods following the Try pattern (TryParse, TryGet, etc.) should return false for expected failure cases rather than throwing exceptions. The JsonSerializer.Deserialize call on line 20 can throw JsonException when the string is not valid JSON, but this should be caught within the method itself and return false instead of propagating to callers.

        public static bool TryUnstringifyJson(JsonElement jsonElement, out JsonElement? result)
        {
            if (jsonElement.ValueKind == JsonValueKind.String)
            {
                var str = jsonElement.GetString() ?? string.Empty;

                result = System.Text.Json.JsonSerializer.Deserialize<JsonElement>(str);
                return true;
            }
            result = null;
            return false;
        }

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.