fix: add ArgumentNullException guards to BaseReflectionConverter#74
Merged
Conversation
…y points Replace cryptic NullReferenceExceptions with explicit ArgumentNullException throwing the parameter name. Guards added to TryModify, TryModifyField, TryModifyProperty, Serialize, SerializeFields, SerializeProperties, Deserialize, TryDeserializeValue, TryDeserializeValueInternal, DeserializeValueAsJsonElement, CreateInstance, and GetDefaultValue.
Contributor
Test Results 2 files 2 suites 9m 1s ⏱️ Results for commit 1087054. ♻️ This comment has been updated with latest results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NullReferenceExceptionwith explicitArgumentNullException(nameof(...))across allBaseReflectionConverter<T>entry pointsTryModify,TryModifyField,TryModifyProperty,Serialize,SerializeFields,SerializeProperties,Deserialize,TryDeserializeValue,TryDeserializeValueInternal,DeserializeValueAsJsonElement,CreateInstance,GetDefaultValuereflector,data/fieldValue/propertyValue,type/objType,obj(where non-nullable)Context
Intermittent
NullReferenceException: Object reference not set to an instance of an objectinTryModifywith certain data models gave no indication of which parameter was null. Now the exception message explicitly names the null argument.Test plan
dotnet build --configuration Release— passesdotnet test --configuration Release— all 1355 tests pass🤖 Generated with Claude Code