Skip to content

fix: add ArgumentNullException guards to BaseReflectionConverter #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
IvanMurzak merged 2 commits into from
Mar 25, 2026
Merged

fix: add ArgumentNullException guards to BaseReflectionConverter #74

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9be5f90
fix: add ArgumentNullException guards to BaseReflectionConverter entr…
IvanMurzak Mar 25, 2026
1087054
fix: add ArgumentNullException guard for null data in Reflector modif…
IvanMurzak Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions ReflectorNet/src/Converter/Reflection/Base/BaseReflectionConverter.DefaultValue.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,8 @@ public abstract partial class BaseReflectionConverter<T> : IReflectionConverter
/// <exception cref="ArgumentException">Thrown when type cannot be instantiated due to constructor limitations.</exception>
public virtual object? CreateInstance(Reflector reflector, Type type)
{
if (type == null)
throw new ArgumentNullException(nameof(type));
if (reflector == null) throw new ArgumentNullException(nameof(reflector));
if (type == null) throw new ArgumentNullException(nameof(type));

// Handle enums
if (type.IsEnum)
Expand Down Expand Up @@ -155,6 +155,9 @@ public abstract partial class BaseReflectionConverter<T> : IReflectionConverter
/// <returns>An appropriate default value for the specified type.</returns>
public virtual object? GetDefaultValue(Reflector reflector, Type type)
{
if (reflector == null) throw new ArgumentNullException(nameof(reflector));
if (type == null) throw new ArgumentNullException(nameof(type));

// Handle nullable types first
if (type.IsGenericType && type.GetGenericTypeDefinition() == typeof(Nullable<>))
return null;
Expand Down
13 changes: 13 additions & 0 deletions ReflectorNet/src/Converter/Reflection/Base/BaseReflectionConverter.Deserialize.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,9 @@ public abstract partial class BaseReflectionConverter<T> : IReflectionConverter
ILogger? logger = null,
DeserializationContext? context = null)
{
if (reflector == null) throw new ArgumentNullException(nameof(reflector));
if (data == null) throw new ArgumentNullException(nameof(data));

if (!TryDeserializeValue(
reflector,
data: data,
Expand Down Expand Up @@ -216,6 +219,8 @@ protected virtual bool TryDeserializeValue(
Logs? logs = null,
ILogger? logger = null)
{
if (reflector == null) throw new ArgumentNullException(nameof(reflector));

if (data == null)
{
result = null;
Expand Down Expand Up @@ -270,6 +275,10 @@ protected virtual bool TryDeserializeValueInternal(
Logs? logs = null,
ILogger? logger = null)
{
if (reflector == null) throw new ArgumentNullException(nameof(reflector));
if (data == null) throw new ArgumentNullException(nameof(data));
if (type == null) throw new ArgumentNullException(nameof(type));

var padding = StringUtils.GetPadding(depth);

if (AllowCascadeSerialization)
Expand Down Expand Up @@ -361,6 +370,10 @@ protected virtual bool TryDeserializeValueInternal(
Logs? logs = null,
ILogger? logger = null)
{
if (reflector == null) throw new ArgumentNullException(nameof(reflector));
if (data == null) throw new ArgumentNullException(nameof(data));
if (type == null) throw new ArgumentNullException(nameof(type));

return reflector.JsonSerializer.Deserialize(
reflector,
data.valueJsonElement,
Expand Down
14 changes: 14 additions & 0 deletions ReflectorNet/src/Converter/Reflection/Base/BaseReflectionConverter.Modify.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,10 @@ public virtual bool TryModify(
BindingFlags flags = BindingFlags.Public | BindingFlags.NonPublic | BindingFlags.Instance,
ILogger? logger = null)
{
if (reflector == null) throw new ArgumentNullException(nameof(reflector));
if (data == null) throw new ArgumentNullException(nameof(data));
if (type == null) throw new ArgumentNullException(nameof(type));

var padding = StringUtils.GetPadding(depth);

if (obj == null)
Expand Down Expand Up @@ -256,6 +260,11 @@ protected virtual bool TryModifyField(
BindingFlags flags = BindingFlags.Public | BindingFlags.NonPublic | BindingFlags.Instance,
ILogger? logger = null)
{
if (reflector == null) throw new ArgumentNullException(nameof(reflector));
if (obj == null) throw new ArgumentNullException(nameof(obj));
if (objType == null) throw new ArgumentNullException(nameof(objType));
if (fieldValue == null) throw new ArgumentNullException(nameof(fieldValue));

var padding = StringUtils.GetPadding(depth);

if (string.IsNullOrEmpty(fieldValue.name))
Expand Down Expand Up @@ -371,6 +380,11 @@ protected virtual bool TryModifyProperty(
BindingFlags flags = BindingFlags.Public | BindingFlags.NonPublic | BindingFlags.Instance,
ILogger? logger = null)
{
if (reflector == null) throw new ArgumentNullException(nameof(reflector));
if (obj == null) throw new ArgumentNullException(nameof(obj));
if (objType == null) throw new ArgumentNullException(nameof(objType));
if (propertyValue == null) throw new ArgumentNullException(nameof(propertyValue));

var padding = StringUtils.GetPadding(depth);

if (string.IsNullOrEmpty(propertyValue.name))
Expand Down
8 changes: 8 additions & 0 deletions ReflectorNet/src/Converter/Reflection/Base/BaseReflectionConverter.Serialize.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@ public virtual SerializedMember Serialize(
ILogger? logger = null,
SerializationContext? context = null)
{
if (reflector == null) throw new ArgumentNullException(nameof(reflector));

var actualType = fallbackType ?? obj?.GetType() ?? typeof(T);

return InternalSerialize(
Expand All @@ -56,6 +58,9 @@ public virtual SerializedMember Serialize(
ILogger? logger = null,
SerializationContext? context = null)
{
if (reflector == null) throw new ArgumentNullException(nameof(reflector));
if (obj == null) throw new ArgumentNullException(nameof(obj));

var serializedFields = default(SerializedMemberList);
var objType = obj.GetType();

Expand Down Expand Up @@ -116,6 +121,9 @@ public virtual SerializedMember Serialize(
ILogger? logger = null,
SerializationContext? context = null)
{
if (reflector == null) throw new ArgumentNullException(nameof(reflector));
if (obj == null) throw new ArgumentNullException(nameof(obj));

var serializedProperties = default(SerializedMemberList);
var objType = obj.GetType();

Expand Down
3 changes: 3 additions & 0 deletions ReflectorNet/src/Reflector/Reflector.Modify.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,9 @@ public bool TryModify(
BindingFlags flags = BindingFlags.Public | BindingFlags.NonPublic | BindingFlags.Instance,
ILogger? logger = null)
{
if (data == null)
throw new ArgumentNullException(nameof(data));

var padding = StringUtils.GetPadding(depth);

if (obj == null && data.IsNull())
Expand Down
Loading