Fix Unity 6.5+ CS0618 deprecations (Light.cookieSize, FindObjectsByType FindObjectsSortMode overload) (#746)

Replaced two Unity 6.5+ deprecated APIs (Light.cookieSize -> cookieSize2D under a UNITY_6000_5_OR_NEWER guard preserving the float wire shape; Object.FindObjectsByType<T>(FindObjectsSortMode) -> parameterless FindObjectsByType<T>() in ScreenshotIsolatedTests). EditMode 911/911 pass, PlayMode 1/1 pass on Unity 2022.3.62f3.

Author: IvanMurzak

Unity-MCP-Plugin/Packages/com.ivanmurzak.unity.mcp/Editor/Scripts/API/Tool/Screenshot.Isolated.cs

@@ -515,7 +515,16 @@ private static void ApplyLightConfig(Light light, Transform xform, IsolatedLight
                 light.colorTemperature = cfg.ColorTemperature.Value;
             }
             if (cfg.CookieSize.HasValue)
+            {
+#if UNITY_6000_5_OR_NEWER
+                // Unity 6.5+ deprecated the float cookieSize in favour of Vector2 cookieSize2D.
+                // The IsolatedLightConfig wire shape stays a single float (uniform XY size) to
+                // preserve backwards-compatible JSON; expand it to (x,y) at the API boundary.
+                light.cookieSize2D = new Vector2(cfg.CookieSize.Value, cfg.CookieSize.Value);
+#else
                 light.cookieSize = cfg.CookieSize.Value;
+#endif
+            }
 
             light.shadows = ParseShadows(cfg.Shadows);
             if (cfg.ShadowStrength.HasValue)

Unity-MCP-Plugin/Packages/com.ivanmurzak.unity.mcp/Tests/Editor/Tool/Screenshot/ScreenshotIsolatedTests.cs

@@ -244,16 +244,16 @@ public void ScreenshotIsolated_NoTemporaryGameObjectsLeftBehind()
             var go = CreateTargetCube("CleanupTarget");
             var goRef = new GameObjectRef { InstanceID = go.GetEntityId() };
 
-            var beforeCount = Object.FindObjectsByType<Camera>(FindObjectsSortMode.None).Length;
+            var beforeCount = Object.FindObjectsByType<Camera>().Length;
 
             new Tool_Screenshot().ScreenshotIsolated(
                 gameObjectRef: goRef,
                 resolution: 32);
 
-            var afterCount = Object.FindObjectsByType<Camera>(FindObjectsSortMode.None).Length;
+            var afterCount = Object.FindObjectsByType<Camera>().Length;
             Assert.AreEqual(beforeCount, afterCount, "All temporary cameras must be destroyed in finally");
 
-            var leftoverLights = new List<Light>(Object.FindObjectsByType<Light>(FindObjectsSortMode.None)).FindAll(l =>
+            var leftoverLights = new List<Light>(Object.FindObjectsByType<Light>()).FindAll(l =>
                 l != null && l.name != null && l.name.StartsWith("__TempIsolation"));
             Assert.AreEqual(0, leftoverLights.Count, "All temporary lights must be destroyed in finally");
         }
@@ -264,26 +264,26 @@ public void ScreenshotIsolated_Composite_NoTemporaryGameObjectsLeftBehind()
             var go = CreateTargetCube("CompositeCleanupTarget");
             var goRef = new GameObjectRef { InstanceID = go.GetEntityId() };
 
-            var beforeCameras = Object.FindObjectsByType<Camera>(FindObjectsSortMode.None).Length;
-            var beforeLights = Object.FindObjectsByType<Light>(FindObjectsSortMode.None).Length;
+            var beforeCameras = Object.FindObjectsByType<Camera>().Length;
+            var beforeLights = Object.FindObjectsByType<Light>().Length;
 
             new Tool_Screenshot().ScreenshotIsolated(
                 gameObjectRef: goRef,
                 cameraView: Tool_Screenshot.CameraView.Composite,
                 resolution: 32);
 
-            var afterCameras = Object.FindObjectsByType<Camera>(FindObjectsSortMode.None).Length;
+            var afterCameras = Object.FindObjectsByType<Camera>().Length;
             Assert.AreEqual(beforeCameras, afterCameras, "All composite-quadrant temporary cameras must be destroyed in finally");
 
             var leftoverIsolation = new List<GameObject>();
-            foreach (var camera in Object.FindObjectsByType<Camera>(FindObjectsSortMode.None))
+            foreach (var camera in Object.FindObjectsByType<Camera>())
             {
                 if (camera != null && camera.name != null && camera.name.StartsWith("__TempIsolation"))
                     leftoverIsolation.Add(camera.gameObject);
             }
             Assert.AreEqual(0, leftoverIsolation.Count, "No __TempIsolationCamera GameObjects must survive a composite render");
 
-            var afterLights = Object.FindObjectsByType<Light>(FindObjectsSortMode.None).Length;
+            var afterLights = Object.FindObjectsByType<Light>().Length;
             Assert.AreEqual(beforeLights, afterLights, "All composite-quadrant temporary lights must be destroyed in finally");
         }