fix: [AI] includeStackTrace not working & DontDestroyOnLoad objects missing in gameobject-find by kisszuopumingdao · Pull Request #836 · IvanMurzak/Unity-MCP

kisszuopumingdao · 2026-06-18T19:35:17Z

Changes

1. Fix includeStackTrace=false not working in console-get-logs

Problem: The includeStackTrace parameter in the console-get-logs tool does not work when set to false. Log
entries still contain StackTrace information even when explicitly disabled.

Root Cause: The includeStackTrace parameter is passed through the entire call chain but never actually used to
filter out the StackTrace property:

FileLogStorage.QueryInternal() receives the parameter but never uses it
BufferedFileLogStorage.QueryInternal() has multiple return points that don't handle the parameter

Fix:

Fix FileLogStorage.QueryInternal() to clear StackTrace based on includeStackTrace before returning results
Fix BufferedFileLogStorage.QueryInternal() to handle includeStackTrace at all return points
Add ClearStackTraceIfNeeded() helper method to ensure consistent behavior

2. Fix DontDestroyOnLoad objects missing in gameobject-find search scope

Problem: When searching by name or path, FindRootGameObjects() only returned active scene root objects. Games using
DontDestroyOnLoad for UI canvases could not be found by gameobject-find.

Fix: Now includes DontDestroyOnLoad root objects when in Play mode.

Testing

console-get-logs

includeStackTrace: false → StackTrace is null
includeStackTrace: true → StackTrace contains stack trace information

gameobject-find

Objects marked with DontDestroyOnLoad are now discoverable when searching in Play mode

When searching by name or path, FindRootGameObjects() only returned active scene root objects. Games using DontDestroyOnLoad for UI canvases could not be found by gameobject-find. Now includes DontDestroyOnLoad root objects when in Play mode. Co-authored-by: AI (Codex) <noreply@openai.com>

- 修复 FileLogStorage.QueryInternal() 中 includeStackTrace 参数未被使用的问题 - 修复 BufferedFileLogStorage.QueryInternal() 中多个返回点未清除 StackTrace 的问题 - 添加 ClearStackTraceIfNeeded() 辅助方法确保行为一致当 includeStackTrace 为 false 时，返回的 LogEntry 中 StackTrace 属性现在会被正确清除为 null

IvanMurzak

Probably weak AI model was used. This pull request has low quality.

IvanMurzak · 2026-06-18T19:59:33Z

+ *  Author: Ivan Murzak (https://github.com/IvanMurzak)
+ *  Repository: GitHub (https://github.com/IvanMurzak/Unity-MCP)
+ *  Copyright (c) 2025 Ivan Murzak
+ *  Licensed under the Apache License, Version 2.0.
+ *  See the LICENSE file in the project root for more information.
+ */


Incorrect header style

IvanMurzak · 2026-06-18T19:59:39Z

+ *  Author: Ivan Murzak (https://github.com/IvanMurzak)
+ *  Repository: GitHub (https://github.com/IvanMurzak/Unity-MCP)
+ *  Copyright (c) 2025 Ivan Murzak
+ *  Licensed under the Apache License, Version 2.0.
+ *  See the LICENSE file in the project root for more information.
+ */


Incorrect header style

IvanMurzak · 2026-06-18T20:00:16Z

+using System.Linq;
 using com.IvanMurzak.McpPlugin.Common;
+using UnityEngine;
 using UnityEngine.SceneManagement;

 namespace com.IvanMurzak.Unity.MCP.Runtime.Utils
 {
    public static partial class GameObjectUtils
    {
        /// <summary>
-        /// Find Root GameObject in opened Prefab. Of array of GameObjects in a scene.
+        /// Find Root GameObject in opened Prefab, active scene, and DontDestroyOnLoad.
        /// </summary>
        /// <param name="scene">Scene for the search, if null the current active scene would be used</param>
        /// <returns>Array of root GameObjects</returns>
-        public static UnityEngine.GameObject[] FindRootGameObjects(Scene? scene = null)
+        public static GameObject[] FindRootGameObjects(Scene? scene = null)
        {
            var prefabStage = UnityEditor.SceneManagement.PrefabStageUtility.GetCurrentPrefabStage();
            if (prefabStage != null)
                return prefabStage.prefabContentsRoot.MakeArray();

+            GameObject[] rootGos;
+
            if (scene == null)
            {
-                var rootGos = UnityEditor.SceneManagement.EditorSceneManager
+                rootGos = UnityEditor.SceneManagement.EditorSceneManager
                    .GetActiveScene()
                    .GetRootGameObjects();
-
-                return rootGos;
            }
            else
            {
-                return scene.Value.GetRootGameObjects();
+                rootGos = scene.Value.GetRootGameObjects();
+            }
+
+            // Include DontDestroyOnLoad root objects (only available at runtime)
+            if (UnityEditor.EditorApplication.isPlaying)
+            {
+                var ddolRoots = Resources.FindObjectsOfTypeAll<GameObject>()
+                    .Where(go => go.scene.name == "DontDestroyOnLoad"
+                        && go.transform.parent == null
+                        && (go.hideFlags == HideFlags.None || go.hideFlags == HideFlags.HideInHierarchy))
+                    .ToArray();
+
+                if (ddolRoots.Length > 0)
+                {
+                    var combined = new GameObject[rootGos.Length + ddolRoots.Length];
+                    rootGos.CopyTo(combined, 0);
+                    ddolRoots.CopyTo(combined, rootGos.Length);
+                    return combined;
+                }
            }
+
+            return rootGos;
        }
-        public static UnityEngine.GameObject? FindByInstanceID(UnityEngine.EntityId instanceID)
+
+        public static GameObject? FindByInstanceID(EntityId instanceID)
        {
-            if (instanceID == UnityEngine.EntityId.None)
+            if (instanceID == EntityId.None)
                return null;

            var obj = UnityEditor.EditorUtility.EntityIdToObject(instanceID);
-            if (obj is not UnityEngine.GameObject go)
+            if (obj is not GameObject go)
                return null;

            return go;


GameObject logic should not be included in the PR about logs stacktrace

IvanMurzak · 2026-06-18T20:00:25Z

@@ -19,7 +18,7 @@ namespace com.IvanMurzak.Unity.MCP.Runtime.Utils
    public static partial class GameObjectUtils
    {
        /// <summary>
-        /// Find Root GameObject in opened Prefab. Of array of GameObjects in a scene.
+        /// Find Root GameObject in opened Prefab, active scene, and DontDestroyOnLoad.
        /// </summary>
        /// <param name="scene">Scene for the search, if null the current active scene would be used</param>
        /// <returns>Array of root GameObjects</returns>
@@ -29,26 +28,47 @@ public static GameObject[] FindRootGameObjects(Scene? scene = null)
            if (prefabStage != null)
                return prefabStage.prefabContentsRoot.MakeArray();

+            GameObject[] rootGos;
+
            if (scene == null)
            {
-                var rootGos = UnityEditor.SceneManagement.EditorSceneManager
+                rootGos = UnityEditor.SceneManagement.EditorSceneManager
                    .GetActiveScene()
                    .GetRootGameObjects();
-
-                return rootGos;
            }
            else
            {
-                return scene.Value.GetRootGameObjects();
+                rootGos = scene.Value.GetRootGameObjects();
+            }
+
+            // Include DontDestroyOnLoad root objects (only available at runtime)
+            if (UnityEditor.EditorApplication.isPlaying)
+            {
+                var ddolRoots = Resources.FindObjectsOfTypeAll<GameObject>()
+                    .Where(go => go.scene.name == "DontDestroyOnLoad"
+                        && go.transform.parent == null
+                        && (go.hideFlags == HideFlags.None || go.hideFlags == HideFlags.HideInHierarchy))
+                    .ToArray();
+
+                if (ddolRoots.Length > 0)
+                {
+                    var combined = new GameObject[rootGos.Length + ddolRoots.Length];
+                    rootGos.CopyTo(combined, 0);
+                    ddolRoots.CopyTo(combined, rootGos.Length);
+                    return combined;
+                }
            }
+
+            return rootGos;
        }
+
        public static GameObject? FindByInstanceID(int instanceID)
        {
            if (instanceID == 0)
                return null;

 #if UNITY_6000_3_OR_NEWER
-            var obj = UnityEditor.EditorUtility.EntityIdToObject((UnityEngine.EntityId)instanceID);
+            var obj = UnityEditor.EditorUtility.EntityIdToObject((EntityId)instanceID);
 #else
            var obj = UnityEditor.EditorUtility.InstanceIDToObject(instanceID);
 #endif


GameObject logic should not be included in the PR about logs stacktrace

IvanMurzak · 2026-06-18T20:01:01Z

                return null;

 #if UNITY_6000_3_OR_NEWER
-            var obj = UnityEditor.EditorUtility.EntityIdToObject((UnityEngine.EntityId)instanceID);


UnityEngine namespace should be explicitly set in each line where a type is used.

IvanMurzak · 2026-06-18T20:01:18Z

+
+        public static GameObject? FindByInstanceID(EntityId instanceID)
        {
-            if (instanceID == UnityEngine.EntityId.None)


UnityEngine namespace should be explicitly set in each line where a type is used.

IvanMurzak · 2026-06-18T20:03:00Z

-                        return result.AsEnumerable().Reverse().ToArray();
+                        return ClearStackTraceIfNeeded(result.AsEnumerable().Reverse().ToArray(), includeStackTrace);
                    }
                }

                result.Add(entry);
                if (result.Count >= maxEntries)
-                    return result.AsEnumerable().Reverse().ToArray();
+                    return ClearStackTraceIfNeeded(result.AsEnumerable().Reverse().ToArray(), includeStackTrace);
            }

            // 2. Exit if we already have enough entries
            var neededLogsCount = maxEntries - result.Count;
            if (neededLogsCount <= 0)
-                return result.AsEnumerable().Reverse().ToArray();
+                return ClearStackTraceIfNeeded(result.AsEnumerable().Reverse().ToArray(), includeStackTrace);

            result.Reverse();

            // 3. Get from file
            var fileEntries = base.QueryInternal(neededLogsCount, logTypeFilter, includeStackTrace, lastMinutes);
            result.AddRange(fileEntries);

-            return result.ToArray();
+            return ClearStackTraceIfNeeded(result.ToArray(), includeStackTrace);
+        }
+
+        private static LogEntry[] ClearStackTraceIfNeeded(LogEntry[] entries, bool includeStackTrace)
+        {
+            if (!includeStackTrace)
+            {
+                foreach (var log in entries)
+                    log.StackTrace = null;
+            }
+            return entries;
        }


This implementation has a weak quality, because it creates an array and then tries to modify after creation. It would be more efficient to use LINQ to generate the proper data using a proper query.

And ideally need to minimize the amount of places where this should be applied to 1, if that is possible.

github-actions · 2026-06-18T20:04:05Z

Test Results

12 files 624 suites 49m 35s ⏱️
892 tests 890 ✅ 1 💤 1 ❌
5 352 runs 5 340 ✅ 6 💤 6 ❌

For more details on these failures, see this check.

Results for commit 35548c5.

kisszuopumingdao and others added 2 commits June 15, 2026 18:39

kisszuopumingdao requested a review from IvanMurzak as a code owner June 18, 2026 19:35

kisszuopumingdao changed the title ~~【AI】fix: includeStackTrace=false not working in console-get-logs~~ 【AI】fix: 1.includeStackTrace=false not working in console-get-logs 2.include DontDestroyOnLoad objects in gameobject-find search scope Jun 18, 2026

kisszuopumingdao changed the title ~~【AI】fix: 1.includeStackTrace=false not working in console-get-logs 2.include DontDestroyOnLoad objects in gameobject-find search scope~~ 【AI】fix: includeStackTrace not working & DontDestroyOnLoad objects missing in gameobject-find Jun 18, 2026

kisszuopumingdao changed the title ~~【AI】fix: includeStackTrace not working & DontDestroyOnLoad objects missing in gameobject-find~~ fix: [AI] includeStackTrace not working & DontDestroyOnLoad objects missing in gameobject-find Jun 18, 2026

IvanMurzak requested changes Jun 18, 2026

View reviewed changes

IvanMurzak assigned kisszuopumingdao Jun 18, 2026

kisszuopumingdao and others added 2 commits June 21, 2026 14:55

Merge branch 'main' into fix/console-get-logs-stacktrace

dfb2e18

Merge branch 'main' into fix/console-get-logs-stacktrace

2c21cda

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: [AI] includeStackTrace not working & DontDestroyOnLoad objects missing in gameobject-find#836

fix: [AI] includeStackTrace not working & DontDestroyOnLoad objects missing in gameobject-find#836
kisszuopumingdao wants to merge 4 commits into
IvanMurzak:mainfrom
kisszuopumingdao:fix/console-get-logs-stacktrace

kisszuopumingdao commented Jun 18, 2026 •

edited

Loading

Uh oh!

IvanMurzak left a comment

Uh oh!

IvanMurzak Jun 18, 2026

Uh oh!

IvanMurzak Jun 18, 2026

Uh oh!

IvanMurzak Jun 18, 2026

Uh oh!

IvanMurzak Jun 18, 2026

Uh oh!

IvanMurzak Jun 18, 2026

Uh oh!

IvanMurzak Jun 18, 2026

Uh oh!

IvanMurzak Jun 18, 2026

Uh oh!

github-actions Bot commented Jun 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

kisszuopumingdao commented Jun 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

1. Fix includeStackTrace=false not working in console-get-logs

2. Fix DontDestroyOnLoad objects missing in gameobject-find search scope

Testing

console-get-logs

gameobject-find

Uh oh!

IvanMurzak left a comment

Choose a reason for hiding this comment

Uh oh!

IvanMurzak Jun 18, 2026

Choose a reason for hiding this comment

Uh oh!

IvanMurzak Jun 18, 2026

Choose a reason for hiding this comment

Uh oh!

IvanMurzak Jun 18, 2026

Choose a reason for hiding this comment

Uh oh!

IvanMurzak Jun 18, 2026

Choose a reason for hiding this comment

Uh oh!

IvanMurzak Jun 18, 2026

Choose a reason for hiding this comment

Uh oh!

IvanMurzak Jun 18, 2026

Choose a reason for hiding this comment

Uh oh!

IvanMurzak Jun 18, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jun 18, 2026

Test Results

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

kisszuopumingdao commented Jun 18, 2026 •

edited

Loading