[ProjectInputStepView]: show "Cancel" instead of "Back" on first dialog step#839
Merged
rorychatt merged 2 commits intoMay 23, 2026
Conversation
Collaborator
Author
Staging removedStaging environment has been deleted for this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Problem
The
ProjectInputStepViewcomponent is used in two different contexts:OnboardingApp.csAddProjectDialog.csCancelAndClose())In
AddProjectDialog, the view is the first step in the flow — there is no previous step to navigate back to. However, the button was hardcoded as "← Back", which is misleading. TheonBackaction actually callsCancelAndClose(), so the button should reflect that.What needed to be done
The button label and icon needed to adapt to the context:
What was changed
ProjectInputStepView.csbackButtonText(default:"Back") — following the existing pattern already used forskipButtonTextandnextButtonTextbackButtonTextinstead of the hardcoded"Back"stringIcons.ArrowLeft) is now conditionally rendered — it only appears when the button text is"Back", and is hidden for"Cancel"since a left arrow doesn't make sense for a cancel actionAddProjectDialog.csbackButtonText: "Cancel"when constructingProjectInputStepViewat step 0No changes to
OnboardingApp.csThe default value
"Back"preserves the existing behavior — no modifications needed.Result