Merge pull request abuzuhri#945 from ProNotion/fix/parameter-based-enum-member-serialisation-clean

fix(parameter-based): respect [EnumMember] attribute when serialising enum query parameters

Author: abuzuhri

Source/FikaAmazonAPI.SampleCode/FinancialSample.cs

@@ -65,7 +65,7 @@ public IList<Transaction> ListFinancialTransactions20240619_ByEventGroup(string
                 new Parameter.Finance.ParameterListFinancialTransactions20240619()
                 {
                     postedAfter = DateTime.UtcNow.AddDays(-30),
-                    relatedIdentifierName = "FINANCIAL_EVENT_GROUP_ID",
+                    relatedIdentifierName = RelatedIdentifier.RelatedIdentifierNameEnum.FINANCIALEVENTGROUPID,
                     relatedIdentifierValue = financialEventGroupId,
                 });
         }

Source/FikaAmazonAPI/Parameter/Finance/ParameterListFinancialTransactions20240619.cs

@@ -19,10 +19,10 @@ public class ParameterListFinancialTransactions20240619 : ParameterBased
         /// </summary>
         public string? transactionStatus { get; set; }
         /// <summary>
-        /// Possible values:`FINANCIAL_EVENT_GROUP_ID`: the financial event group ID associated with the transaction.
-        ///*Note: FINANCIAL_EVENT_GROUP_ID is the only `relatedIdentifier` with filtering capabilities at the moment. While other `relatedIdentifier` values will be included in the response when available, they cannot be used for filtering purposes.
+        /// The identifier name to filter by. Only FINANCIAL_EVENT_GROUP_ID has filtering capability at the moment;
+        /// other values appear in response payloads but cannot be used as query filters.
         /// </summary>
-        public string? relatedIdentifierName { get; set; }
+        public RelatedIdentifierNameEnum? relatedIdentifierName { get; set; }
         public string? relatedIdentifierValue { get; set; }
         public string nextToken { get; set; }
         public int? MaxNumberOfPages { get; set; }

Source/FikaAmazonAPI/Parameter/ParameterBased.cs

@@ -57,11 +57,22 @@ public virtual List<KeyValuePair<string, string>> getParameters()
                     }
                     else if (p.PropertyType.IsEnum || IsNullableEnum(p.PropertyType))
                     {
-                        output = value.ToString();
+                        var enumSettings = new JsonSerializerSettings
+                        {
+                            Converters = new List<JsonConverter> { new StringEnumConverter() }
+                        };
+                        output = JsonConvert.SerializeObject(value, enumSettings).Trim('"');
                     }
                     else if (IsEnumerableOfEnum(p.PropertyType) || IsEnumerable(p.PropertyType))
                     {
-                        var data = ((ICollection)value).Cast<object>().Select(a => a.ToString());
+                        var enumSettings = new JsonSerializerSettings
+                        {
+                            Converters = new List<JsonConverter> { new StringEnumConverter() }
+                        };
+                        var data = ((ICollection)value).Cast<object>()
+                            .Select(a => a.GetType().IsEnum
+                                ? JsonConvert.SerializeObject(a, enumSettings).Trim('"')
+                                : a.ToString());
                         if (data.Count() > 0)
                         {
                             var result = data.ToArray();